Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid datetime format with fetchlead command #7042

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Enc3phale
Copy link
Contributor

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

Complement of #6483
Prevent SQLSTATE[22007]: Invalid datetime format: 1292 Incorrect date

When create new company with fetchlead command php app/console mautic:integration:fetchleads --time-interval=2minutes --integration=Salesforce, cause of code order, matchedFields are not transformed for SQL.

I think this PR need only code checking, I have juste inverted code.

@Woeler Woeler added this to the 2.15.1 milestone Dec 21, 2018
@Woeler Woeler added the bug Issues or PR's relating to bugs label Dec 21, 2018
@npracht npracht added this to Code Review (2 required) in Mautic 2 Jan 3, 2019
@npracht npracht moved this from Code Review (2 required) to Ready to Test (confirmation) in Mautic 2 Jan 3, 2019
@npracht npracht added the pending-test-confirmation PR's that require one test before they can be merged label Jan 3, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Jan 3, 2019
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better 👍

@npracht npracht moved this from Ready to Test (first time) to Ready to Test (confirmation) in Mautic 2 Jan 3, 2019
@alanhartless alanhartless added this to Needs Second Test in 2.15.1 Jan 14, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Jan 15, 2019
@alanhartless alanhartless merged commit 52acca3 into mautic:staging Jan 15, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 15, 2019
@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Jan 15, 2019
@alanhartless alanhartless removed pending-test-confirmation PR's that require one test before they can be merged labels Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs
Projects
No open projects
2.15.1
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants