Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact exists check before setting locale #7089

Merged
merged 2 commits into from Jan 14, 2019
Merged

Contact exists check before setting locale #7089

merged 2 commits into from Jan 14, 2019

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Jan 3, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? N
Deprecations? N

Description:

Fixing this error:

Uncaught PHP Exception Symfony\Component\Debug\Exception\FatalThrowableError: "Call to a member function getPreferredLocale() on null" at app/bundles/EmailBundle/Controller/PublicController.php line 310

https://github.com/mautic/mautic/pull/6135/files fixed similar error for unsubscribe.

Steps to reproduce the bug:

  1. Send an email with unsubscribe link to a contact
  2. Click the unsubscribe link in the received email
  3. Delete the contact
  4. Click the unsubscribe link again (the intent is to resubscribe)
  • error

Steps to test this PR:

  1. Click the unsubscribe link again
  • No error

Although this only fixes the error. There is no way the deleted contact can be un/resubscribed.

@escopecz escopecz added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Jan 3, 2019
@escopecz escopecz added this to the 2.15.1 milestone Jan 3, 2019
@mleffler
Copy link
Contributor

mleffler commented Jan 3, 2019

Tested and works properly, also code reviewed and running in our production environment.

@mleffler mleffler added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Jan 3, 2019
@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Jan 3, 2019
@alanhartless alanhartless added this to Needs Second Test in 2.15.1 Jan 14, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Jan 14, 2019
@alanhartless alanhartless merged commit 86ed6e8 into mautic:staging Jan 14, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 14, 2019
@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Jan 15, 2019
@alanhartless alanhartless removed pending-test-confirmation PR's that require one test before they can be merged labels Jan 16, 2019
@alanhartless alanhartless deleted the contact-exists-check-before-setting-locale branch April 18, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs T1 Low difficulty to fix (issue) or test (PR)
Projects
No open projects
2.15.1
Merged
Milestone
2.15.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@escopecz @mleffler @alanhartless @Woeler