Add company mapping and api key for ExtremeIpLookup #7104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npracht
added
ready-to-test
npracht
added
WIP
|
I put it under |
Mautic 2
automation
moved this from Ready to Test (first time)
to Changes Requested / Review
Jan 22, 2019
|
Working now! Key was wrong and PR #7083 solve Company name mapping. |
npracht
added
pending-test-confirmation
alanhartless
approved these changes
Jan 30, 2019
Mautic 2
automation
moved this from Changes Requested / Review
to Ready to Test (first time)
Jan 30, 2019
|
Does this populate Company name field to anonymous contact records? |
|
it does ! |
|
@npracht - Awesome and thanks for your response. I have thousands of anonymous contacts with extensive history. I've been using the Maxmind IP service to collect these anonymous contacts. I switched over to ExtremeIpLookup today with no username or password. Should it be collecting the company name and populating the existing anonymous contacts? |
|
@robbiereynolds it is not doing the job for the past contacts. Maybe if they are active again it does work but not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When using the Extreme Ip Lookup service, the company name was not mapped with mautic company field. Also, if you subscribed to a Pro service to unlock the limit of API call, the API key was not used.
Steps to test this PR:
A bit annoying because you need a pro account to test the API key. But just reviewing the code should be enough.