Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Custom field is used" message #7157

Merged
merged 1 commit into from Mar 11, 2019
Merged

Update "Custom field is used" message #7157

merged 1 commit into from Mar 11, 2019

Conversation

anton-vlasenko
Copy link
Contributor

@anton-vlasenko anton-vlasenko commented Jan 22, 2019 •
edited

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
BC breaks? N
Deprecations? N

Description:

  1. Updated messages so users can see extended information about reasons why they cannot delete a custom field(s)
  2. It was possible to delete custom fields used in segments via mass delete functionality. Now this is not possible.

Steps to reproduce the bug:

  1. Create 2 custom fields.
  2. Use one of the custom fields in a segment.
  3. Select these fields and mass delete them.
  4. Both fields are deleted, despite the fact that one of the fields was used in a segment.

Steps to test this PR:

  1. Try to delete a custom field that is used in a segment. You will get an extended information about what Segments prevent this custom field from being deleted.

@npracht npracht added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Jan 24, 2019
@alanhartless alanhartless added the pending-test-confirmation PR's that require one test before they can be merged label Jan 30, 2019
@alanhartless alanhartless added this to the 2.15.1 milestone Jan 30, 2019
@alanhartless alanhartless added this to Needs Second Test in 2.15.1 Jan 31, 2019
@npracht npracht removed the ready-to-test PR's that are ready to test label Feb 6, 2019
npracht
npracht approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged labels Mar 8, 2019
@alanhartless alanhartless merged commit 0ce5231 into mautic:staging Mar 11, 2019
@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Mar 11, 2019
@alanhartless alanhartless deleted the staging.update-custom-field-is-used-message branch April 18, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
2.15.1
Merged
Milestone
2.15.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anton-vlasenko @alanhartless @npracht