Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dnc reason text in lead view #7161

Merged
merged 8 commits into from Mar 11, 2019
Merged

Fix dnc reason text in lead view #7161

merged 8 commits into from Mar 11, 2019

Conversation

hluchas
Copy link
Contributor

@hluchas hluchas commented Jan 22, 2019

Q A
Bug fix? Y
New feature?
Automated tests included? Y
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

We used to display the reason (e.g. unsubscribe") but now we just display a number instead.

Steps to reproduce the bug:

  1. Go to contacts, choose one with DNC status, click to view contact data and hover over the DNC red box.
    snimek obrazovky 2019-01-15 v 15 41 58

Or you can add DNC record by yourself.

Steps to test this PR:

  1. Same as reproduction text but you will get string in the tooltip.

@npracht npracht added bug Issues or PR's relating to bugs user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Jan 24, 2019
@alanhartless alanhartless added this to the 2.15.1 milestone Jan 30, 2019
@alanhartless alanhartless added the pending-test-confirmation PR's that require one test before they can be merged label Jan 30, 2019
alanhartless
alanhartless previously approved these changes Jan 30, 2019
View reviewed changes
@alanhartless alanhartless added this to Needs Second Test in 2.15.1 Jan 31, 2019
@npracht npracht removed the ready-to-test PR's that are ready to test label Mar 5, 2019
kuzmany
kuzmany approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Mautibox https://mautibox.com/7161/s/contacts/view/50
Works properly
Code looks good ;)

@kuzmany kuzmany added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Mar 6, 2019
@npracht npracht removed the code-review-needed PR's that require a code review before merging label Mar 6, 2019
@alanhartless alanhartless merged commit c9847de into mautic:staging Mar 11, 2019
@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Mar 11, 2019
@alanhartless alanhartless deleted the fix-dnc-reason-text-in-lead-view branch April 18, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottshipman scottshipman scottshipman requested changes

@kuzmany kuzmany kuzmany approved these changes

@alanhartless alanhartless alanhartless left review comments

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged user-interface Anything related to appearance, layout, and interactivity
Projects
No open projects
2.15.1
Merged
Milestone
2.15.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hluchas @alanhartless @kuzmany @scottshipman @npracht