Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent $connector from getting serialized into the $details array #7192

Merged
merged 1 commit into from May 19, 2019

Conversation

alanhartless
Copy link
Contributor

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Somehow, Joomla's Http object is serialized for some but not for all IP address details.

Uncaught PHP Exception Doctrine\DBAL\Types\ConversionException: "Serialized array includes null-byte. This cannot be saved as a text. Please check if you not provided object with protected or private members. Serialized Array: a:11:{s:4:"city";s:6:"Tirana";s:6:"region";s:15:"Qarku i Tiranes";s:7:"zipcode";N;s:7:"country";s:7:"Albania";s:8:"latitude";d:41.3275;s:9:"longitude";d:19.8189;s:3:"isp";s:0:"";s:12:"organization";s:0:"";s:8:"timezone";s:13:"Europe/Tirane";s:5:"extra";s:0:"";s:9:"connector";O:16:"Joomla\Http\Http":2:{s:10:"__NULL_BYTE__*__NULL_BYTE__options";a:0:{}s:12:"__NULL_BYTE__*__NULL_BYTE__transport";O:26:"Joomla\Http\Transport\Curl":1:{s:10:"__NULL_BYTE__*__NULL_BYTE__options";a:0:{}}}}" at app/bundles/CoreBundle/Doctrine/Type/ArrayType.php line 48

It was because the old IP address code used Reflection to get the properties but $connector was not defined and thus considered public. No idea why this is not more widespread.

Steps to reproduce the bug:

  1. No idea :-)

@alanhartless alanhartless added bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged labels Jan 31, 2019
@alanhartless alanhartless added this to the 2.15.1 milestone Jan 31, 2019
@alanhartless
Copy link
Contributor Author

This has been reviewed by our team and in production for months now so marking as pending test confirmation.

@escopecz escopecz added this to Needs Second Test in 2.15.1 Jan 31, 2019
@alanhartless alanhartless modified the milestones: 2.15.1, 2.16.0 Mar 11, 2019
@alanhartless alanhartless removed this from Needs Second Test in 2.15.1 Mar 11, 2019
@npracht npracht modified the milestones: 2.16.0, 2.15.2 Mar 28, 2019
@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Apr 4, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) May 19, 2019
@kuzmany kuzmany added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels May 19, 2019
@kuzmany kuzmany merged commit 9806f6d into mautic:staging May 19, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
Mautic 2
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants