Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents an exception for DWC and focus requests that aren't tracked #7197

Merged
merged 3 commits into from May 19, 2019

Conversation

alanhartless
Copy link
Contributor

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

There are some scenarios where DWC and focus endpoints are not tracked leading to an exception when Doctrine tries to save a stat. This is happening most on sites with multiple tracking code snippets embedded (another bug to deal with).

Steps to reproduce the bug:

  1. Create dynamic web content -> turn campaign based off and add a filter that would match any contact (country != mars or something like that). Note the slot name you used.
  2. Open a guest/incognito browser session
  3. browse to your-mautic.com/dwc/slot (replace slot with the name used in step 1)
  4. Note the exception
  5. Go back to the logged in session and visit the same URL - notice the different exception

Steps to test this PR:

  1. Repeat and no exception will be thrown
  2. Repeat while logged into Mautic and no exception will be thrown

@alanhartless alanhartless added bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged labels Jan 31, 2019
@alanhartless alanhartless added this to the 2.15.1 milestone Jan 31, 2019
@alanhartless
Copy link
Contributor Author

Our team has reviewed this and it's been in production for months now so marking as pending test confirmation

@escopecz escopecz added this to Needs Second Test in 2.15.1 Jan 31, 2019
@alanhartless alanhartless removed this from Needs Second Test in 2.15.1 Mar 11, 2019
@alanhartless alanhartless modified the milestones: 2.15.1, 2.16.0 Mar 11, 2019
@npracht npracht modified the milestones: 2.16.0, 2.15.2 Mar 28, 2019
@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Apr 4, 2019
@kuzmany kuzmany added the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label May 19, 2019
@kuzmany
Copy link
Member

kuzmany commented May 19, 2019

@alanhartless Can you resolve conflicts?

@kuzmany kuzmany added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed has-conflicts Pull requests that cannot be merged until conflicts have been resolved pending-test-confirmation PR's that require one test before they can be merged labels May 19, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) May 19, 2019
@kuzmany kuzmany merged commit a26ab81 into mautic:staging May 19, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
Mautic 2
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants