Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipedrive activities support #7233
Pipedrive activities support #7233
Changes from 11 commits
37d9279
5fc769e
8f687ec
1753c2c
2fa71a4
2c2c081
f2d87ff
09bb031
408e2dc
718bef3
bf1ab86
5b50816
5bdbbd0
986ab88
accce1b
928dc0b
0e5399e
0f2da26
727ab30
c798ec1
dcf69ec
6ad4f2b
b06b1fe
0294f1b
112d64b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second param should be max count (the count of 100%). 50 is a wild guess of how many integration entities there are. You should count the amount of integration entities that will be processed instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is we don't know how many items will be processed.
We store lastActivitySync timestamp to internal serialize column.
This is reason why we have to run all integration entity in batch, then just skipped already updated https://github.com/mautic/mautic/pull/7233/files#diff-6bdf0596bca5f7bff88ba72d06c7683dR78
I know It's not the best solution, but I didn't better idea how to figure out.
Maybe we can use regexp on intetrnal column and this should work too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, may be good idea to make the limit configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second param should be max count (the count of 100%). 50 is a wild guess of how many integration entities there are. You should count the amount of integration entities that will be processed instead.