Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom field with type text requires string shorter than 256 chars #7283

Merged
merged 2 commits into from May 19, 2019

Conversation

hluchas
Copy link
Contributor

@hluchas hluchas commented Feb 26, 2019

Q A
Bug fix? Y
New feature?
Automated tests included? Y
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #3863
BC breaks?
Deprecations?

Description:

App throws DB exception when limit for varchar in DB exceeded. I added own validator to use string representation of array value.

Steps to reproduce the bug:

  1. Use Postman
    44588081-0e8f6d80-a7b5-11e8-8e00-c0726aeafbb1

or
2. Create a form with 1 multiselect field
3. Map it to the First Name field which is text
4. Try to submit

Steps to test this PR:

  1. Same as reproduction steps

@npracht npracht added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Feb 26, 2019
@alanhartless alanhartless added this to the 2.16.0 milestone Mar 12, 2019
@npracht npracht modified the milestones: 2.16.0, 2.15.2 Mar 28, 2019
@npracht npracht added this to Ready to Test (first time) in Mautic 2 Apr 4, 2019
@npracht
Copy link
Member

npracht commented Apr 26, 2019

@hluchas can you have a look at conflicts please ?
Thanks !

@kuzmany kuzmany self-requested a review May 12, 2019 10:44
@kuzmany kuzmany added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels May 12, 2019
@escopecz escopecz moved this from Ready to Test (first time) to Ready to Test (confirmation) in Mautic 2 May 13, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) May 19, 2019
@kuzmany kuzmany added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels May 19, 2019
@kuzmany kuzmany merged commit 3626ea1 into mautic:staging May 19, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-needed PR's that require a code review before merging ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
Mautic 2
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants