Fix "check all" checkbox for tables loaded via ajax #7310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the staging branch.
Description:
This issue this PR is fixing happens when the table is loaded via AJAX in a tab. In this scenario the
target
is null and later it will find allparentsUntil(null)
which means all and removes theactive
class from them. Normally, there is no harm in that, but tabs useactive
class too and when removed the content disappears.The solution I suggest is to read the target on change event. Not only on load which is useless for content loaded asynchronously.
Steps to reproduce the bug:
Steps to test this PR: