Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CreatedDate to Salesforce integration #7404

Merged
merged 3 commits into from Aug 17, 2019
Merged

Add CreatedDate to Salesforce integration #7404

merged 3 commits into from Aug 17, 2019

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Apr 10, 2019 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR added support for sync CreatedDate from Salesforce to Mautic.
This fieldcannot be update on Salesforce, then this field have to just one way (to Mautic sync).
This PR added option to force direction for any field. For this example we use it for CreatedDate

Steps to test this PR:

  1. Load up this PR
  2. Setup Salesforce https://www.mautic.org/docs/en/plugins/salesforce.html
  3. Find Created Date in field list and setup mapping to any custom date field

image

  1. Call php app/console mautic:integration:fetchleads --integration=Salesforce
  2. Check If Created date was synced to Mautic

@kuzmany kuzmany added WIP PR's that are not ready for review and are currently in progress enhancement Any improvement to an existing feature or functionality labels Apr 10, 2019
@npracht npracht added this to the 2.16.0 milestone Apr 10, 2019
@kuzmany kuzmany added ready-to-test PR's that are ready to test and removed WIP PR's that are not ready for review and are currently in progress labels Apr 10, 2019
@npracht npracht added the code-review-needed PR's that require a code review before merging label Apr 10, 2019
npracht
npracht approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works properly. If next can have a look at the code please.

@npracht npracht added pending-test-confirmation PR's that require one test before they can be merged plugin Anything related to plugins and removed ready-to-test PR's that are ready to test labels Apr 25, 2019
@npracht
Copy link
Member

npracht commented May 3, 2019 •
edited

Using in production environment.

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Aug 17, 2019
@Woeler Woeler merged commit 6c3e713 into mautic:staging Aug 17, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged Aug 17, 2019
@Woeler Woeler modified the milestones: 2.16.0, 2.15.3 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npracht npracht npracht approved these changes

@Woeler Woeler Woeler approved these changes

Assignees
No one assigned
Labels
code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality pending-test-confirmation PR's that require one test before they can be merged plugin Anything related to plugins
Projects
No open projects
Mautic 2
  
Merged
Milestone
2.15.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuzmany @npracht @Woeler