Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent destroyChosen call function on null #7407

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Projects
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Apr 11, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Steps to reproduce the bug:

  1. Create a report
  2. Choose Emails Sent as "Data Source"
  3. In data tab Add Filter
  4. Choose filter Bounced or another bool type
  5. Then try change to another non bool filter
  6. You should see rrror in console: TypeError: owner is undefined

Steps to test this PR:

  1. Load up this PR
  2. Without Mautibox require php app/console mautic:assets:generate
  3. Repeat all steps to reproduce, should work properly

@kuzmany kuzmany added this to the 2.15.2 milestone Apr 11, 2019

@Enc3phale
Copy link
Contributor

Enc3phale left a comment

Tested and it's work as expected, thanks!

@npracht
Copy link
Member

npracht left a comment

👍 good job

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Apr 12, 2019

@npracht npracht moved this from Ready to Test (confirmation) to Ready to Commit (passed testing) in Mautic 2 Apr 12, 2019

@kuzmany kuzmany merged commit 3fd4536 into mautic:staging Apr 13, 2019

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.