Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent destroyChosen call function on null #7407

Merged
merged 1 commit into from Apr 13, 2019
Merged

Prevent destroyChosen call function on null #7407

merged 1 commit into from Apr 13, 2019

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Apr 11, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Steps to reproduce the bug:

  1. Create a report
  2. Choose Emails Sent as "Data Source"
  3. In data tab Add Filter
  4. Choose filter Bounced or another bool type
  5. Then try change to another non bool filter
  6. You should see rrror in console: TypeError: owner is undefined

Steps to test this PR:

  1. Load up this PR
  2. Without Mautibox require php app/console mautic:assets:generate
  3. Repeat all steps to reproduce, should work properly

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Apr 11, 2019
@kuzmany kuzmany added this to the 2.15.2 milestone Apr 11, 2019
Enc3phale
Enc3phale approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@Enc3phale Enc3phale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's work as expected, thanks!

@npracht npracht added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Apr 12, 2019
npracht
npracht approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good job

@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Apr 12, 2019
@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Apr 12, 2019
@npracht npracht moved this from Ready to Test (confirmation) to Ready to Commit (passed testing) in Mautic 2 Apr 12, 2019
@kuzmany kuzmany merged commit 3fd4536 into mautic:staging Apr 13, 2019
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npracht npracht npracht approved these changes

@Enc3phale Enc3phale Enc3phale approved these changes

Assignees

@johbuch johbuch

Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
Mautic 2
  
Merged
Milestone
2.15.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuzmany @npracht @Enc3phale @johbuch