Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc block fixes #7412

Merged
merged 2 commits into from May 8, 2019
Merged

Doc block fixes #7412

merged 2 commits into from May 8, 2019

Conversation

escopecz
Copy link
Sponsor Member

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? N
Deprecations? N

Description:

We've got PHPSTAN level 5 errors in our plugin which had to be fixed in Mautic itself. So here they are.

Parameter #2 $location of method Mautic\CoreBundle\Event\CustomButtonEvent::addButton() expects null,
Parameter #2 $channelId of method Mautic\CampaignBundle\Event\CampaignExecutionEvent::setChannel() expects null, int given
Parameter #3 $columnName of method Mautic\CoreBundle\Doctrine\Mapping\ClassMetadataBuilder::addNullableField() expects null, string given.
Parameter #3 $afterDate of method Mautic\CoreBundle\Model\AuditLogModel::getLogForObject() expects null, DateTime given.
Parameter #7 $entityIdColumnName of method MauticPlugin\CustomObjectsBundle\Controller\CustomItem\ContactListController::generateContactsGrid() expects null, string given.

Steps to test this PR:

  1. There is no code change so this PR cannot break anything. Just method doc block changes. Code review is good enough.

@escopecz escopecz added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Apr 12, 2019
@npracht npracht added this to the 2.15.2 milestone Apr 12, 2019
@npracht npracht added this to Ready to Test (first time) in Mautic 2 Apr 12, 2019
@kuzmany kuzmany added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test labels May 8, 2019
@kuzmany kuzmany merged commit 0740500 into mautic:staging May 8, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
Mautic 2
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants