Prevent an exception when a contact is deleted between the time logs … #7443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are loaded into memory and contacts are hydrated.
alanhartless
added
bug
kuzmany
added
pending-test-confirmation
escopecz
moved this from Ready to Test (first time)
to Ready to Test (confirmation)
in Mautic 2
kuzmany
approved these changes
May 19, 2019
Mautic 2
automation
moved this from Ready to Test (confirmation)
to Ready to Test (first time)
May 19, 2019
kuzmany
added
ready-to-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the staging branch.
Description:
An exception will be thrown if a contact is deleted between the time event logs to be executed are loaded into memory and the time contacts are hydrated with custom field values due to signature mismatches. This PR simply handles that gracefully.
Steps to reproduce the bug:
Steps to test this PR: