Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribed Manual segment filter #7475

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

commented Apr 27, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Just new segment filter with manual unsubscribed contacts

Steps to test this PR:

  1. Load up this PR
  2. Create segment with new filter "Unsubscribed Manual - Email"
  3. Go to any contact's detail, open preferences and unsubscribe contact from email channel
  4. call php app/console mautic:segments:update
  5. See If contacts was added to segment
@kuzmany

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

We're using this pull request in production from the date of created.
Works properly.

@AlbanL74fr

This comment has been minimized.

Copy link

commented May 12, 2019

It works as expected (cc: @kuzmany )

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

@escopecz Please, can you make code review and aprove it too. There are two successful tests, but I cannot approve my own PR

Mautic 2 automation moved this from Changes Requested / Review to Ready to Test (first time) May 13, 2019

@escopecz
Copy link
Member

left a comment

Code looks fine 👍

@escopecz escopecz moved this from Ready to Test (first time) to Ready to Commit (passed testing) in Mautic 2 May 13, 2019

@kuzmany kuzmany merged commit be1d6e4 into mautic:staging May 13, 2019

2 checks passed

Scrutinizer Analysis: 2 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.