Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsubscribed Manual segment filter #7475

Merged
merged 1 commit into from May 13, 2019
Merged

Unsubscribed Manual segment filter #7475

merged 1 commit into from May 13, 2019

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Apr 27, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Just new segment filter with manual unsubscribed contacts

Steps to test this PR:

  1. Load up this PR
  2. Create segment with new filter "Unsubscribed Manual - Email"
  3. Go to any contact's detail, open preferences and unsubscribe contact from email channel
  4. call php app/console mautic:segments:update
  5. See If contacts was added to segment

@kuzmany kuzmany added ready-to-test PR's that are ready to test enhancement Any improvement to an existing feature or functionality labels Apr 27, 2019
@kuzmany kuzmany added this to the 2.15.2 milestone Apr 27, 2019
@kuzmany kuzmany mentioned this pull request Apr 27, 2019
Closed
@npracht npracht added this to Changes Requested / Review in Mautic 2 May 2, 2019
@kuzmany
Copy link
Member Author

kuzmany commented May 3, 2019

We're using this pull request in production from the date of created.
Works properly.

@kuzmany kuzmany added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels May 3, 2019
@albanleandri
Copy link

It works as expected (cc: @kuzmany )

@kuzmany
Copy link
Member Author

kuzmany commented May 12, 2019

@escopecz Please, can you make code review and aprove it too. There are two successful tests, but I cannot approve my own PR

Mautic 2 automation moved this from Changes Requested / Review to Ready to Test (first time) May 13, 2019
escopecz
escopecz approved these changes May 13, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine 👍

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels May 13, 2019
@escopecz escopecz moved this from Ready to Test (first time) to Ready to Commit (passed testing) in Mautic 2 May 13, 2019
@kuzmany kuzmany merged commit be1d6e4 into mautic:staging May 13, 2019
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged May 13, 2019
@escopecz escopecz mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@albanleandri albanleandri albanleandri approved these changes

Assignees
No one assigned
Labels
enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
Mautic 2
  
Merged
Milestone
2.15.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuzmany @albanleandri @escopecz