Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access_token expired after 1 hour for Go To plugins #7531

Merged
merged 7 commits into from Aug 17, 2019

Conversation

@kuzmany
Copy link
Member

@kuzmany kuzmany commented May 14, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

2.15.2 add new Adapt GoTo plugin for oauth2 authentication #7380
But according to the documentation https://goto-developer.logmeininc.com/how-use-refresh-tokens access_token expire every one hour.
This PR try identify If access_token is invalid and then try refresh it (docs above)

Steps to reproduce the bug:

  1. Setup GOTO plugin (webinar for example)
  2. Authorize, and try use it one hour later. If you are on dev enviroment, you should see error in logs

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps. You access token should refresh after one hour
@kuzmany kuzmany added this to the 2.15.2 milestone May 14, 2019
@johbuch
Copy link
Contributor

@johbuch johbuch commented May 15, 2019

hi zdeno, I created a new app in gotowebinar, then set the plugin but when I want to push contact to webinar through a form, I can't because my webinar does not appear
image
I should have a webinar displayed

@kuzmany
Copy link
Member Author

@kuzmany kuzmany commented May 15, 2019

It's new issue?
Or it happend after upgrade?
Could you share with me goto credentials?

@johbuch
Copy link
Contributor

@johbuch johbuch commented May 15, 2019

@kuzmany we patched this PR on my instance, I could set and authorised the plugin, but then webinars don't display.
i wrote you on slack

@kuzmany kuzmany removed this from the 2.15.2 milestone May 19, 2019
@npracht npracht added this to the 2.16.0 milestone May 20, 2019
@kuzmany
Copy link
Member Author

@kuzmany kuzmany commented May 20, 2019

@johbuch last commit fixed it.

Copy link
Contributor

@Enc3phale Enc3phale left a comment

Tested and it works! Thanks!

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
Woeler
Woeler approved these changes Aug 17, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Aug 17, 2019
@Woeler Woeler merged commit b212ab0 into mautic:staging Aug 17, 2019
2 checks passed
Mautic 2 automation moved this from Ready to Test (first time) to Merged Aug 17, 2019
@Woeler Woeler removed this from the 2.16.0 milestone Sep 27, 2019
@Woeler Woeler added this to the 2.15.3 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Mautic 2
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants