Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SugarCrm sync priority for form push #7555

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@Enc3phale
Copy link
Contributor

Enc3phale commented May 23, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? Y
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

Add SugarCRM priority sync when data is sync with form action.
Fix some warning like:

Warning: Invalid argument supplied for foreach() in \plugins\MauticCrmBundle\Integration\SugarcrmIntegration.php on line 1505

Notice: Undefined index: Leads in \plugins\MauticCrmBundle\Integration\SugarcrmIntegration.php on line 1344

PHP Warning:  array_keys() expects parameter 1 to be array, null given in \plugins\MauticCrmBundle\Integration\SugarcrmIntegration.php on line 1466

Warning: Invalid argument supplied for foreach() in \plugins\MauticCrmBundle\Integration\SugarcrmIntegration.php on line 1347

Steps to reproduce the bug:

  1. Install and configure SugarCRM
  2. Map fields for Contact
  3. Put First Name for Contact on Mautic priority
  4. Create a contact with an Email a First Name and a Mobile phone in SugarCrm
  5. Run sync with command mautic:integration:fetchleads
  6. Create a standalone form with Email field, First Name field and a Mobile phone field
  7. Add form action "Push contact to integration" and choose "SugarCrm"
  8. Go to this form in private navigation and submit it with Email of previous created Lead but use an other First Name and an other Mobile phone.
  9. First Name and Mobile phone is pushed to SugarCrm without check of priority

Steps to test this PR:

  1. Load up this PR
  2. Repeat step above
  3. Only First Name is pushed to SugarCrm.
@npracht npracht added this to the 2.16.0 milestone May 24, 2019
@npracht npracht added the Plugin label May 24, 2019
@npracht
npracht approved these changes Jul 2, 2019
Copy link
Member

npracht left a comment

Used in production environment with success for weeks now 👍

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Aug 17, 2019
@Woeler
Woeler approved these changes Aug 17, 2019
@Woeler Woeler merged commit 4887382 into mautic:staging Aug 17, 2019
2 checks passed
2 checks passed
Scrutinizer Analysis: 1 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Test (first time) to Merged Aug 17, 2019
@Woeler Woeler modified the milestones: 2.16.0, 2.15.3 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
3 participants
You can’t perform that action at this time.