Watch out for failures to parse webhooks #7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"if [[ ${TRAVIS_PHP_VERSION:0:3} == "7.2" ]]; then bin/php-cs-fixer fix -v --dry-run --diff; fi" exited with 8. Exit codes
----------
Exit code is built using following bit flags:
* 0 OK.
* 1 General error (or PHP/HHVM minimal requirement not matched).
* 4 Some files have invalid syntax (only in dry-run mode).
* 8 Some files need fixing (only in dry-run mode).
* 16 Configuration error of the application.
* 32 Configuration error of a Fixer.
* 64 Exception raised within the application. |
aspiers
force-pushed
the
ses-webhook-logging
branch
from
945eb58
to
93540d5
Compare
In theory this should never happen, but defensive programming just in case is usually a good idea.
aspiers
force-pushed
the
ses-webhook-logging
branch
from
93540d5
to
10e8408
Compare
kuzmany
added
pending-test-confirmation
virgilwashere
approved these changes
Aug 15, 2019
Mautic 2
automation
moved this from Ready to Test (confirmation)
to Ready to Test (first time)
Aug 17, 2019
Woeler
removed
the
pending-test-confirmation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log useful messages just in case anything goes wrong with parsing of the webhook payload. In theory this should never happen, but defensive programming just in
case is usually a good idea.
Steps to test this PR: