Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overwrite custom field value with default value during redirection #7595

Open
wants to merge 2 commits into
base: staging
from

Conversation

Projects
None yet
2 participants
@kuzmany
Copy link
Contributor

commented Jun 11, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Noticed issue with contact field default value.
If Mautic create contact and already have contact in url (ct), Mautic create new anonymouse contact first and then merge it with founded contact.
This make mess, because If our founded contact already exist and we modified custom field, then during the merge method, these two contact are merged and value is overwritten to default value.

Steps to reproduce the bug:

  1. Create custom field with default value
  2. Create contact (default values is filled)
  3. Change default value
  4. Create email with anchor link to http://mautic.org
  5. Send email to contact
  6. Copy redirect link from email
  7. Open this link in incognito window
  8. See value of custom field was set to default value (what we don't expect)

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps
  3. See If value of custom field is not overwrite to default value

@kuzmany kuzmany added this to the 2.16.0 milestone Jun 11, 2019

@kuzmany kuzmany changed the title Fix getContactFromQuery If contact exist in query Fix getContactFromQuery If contact exists in query Jun 11, 2019

@kuzmany kuzmany changed the title Fix getContactFromQuery If contact exists in query Fix overwrite custom field value with default value during redirection Jun 11, 2019

@florentpetitjean

This comment has been minimized.

Copy link

commented Jun 12, 2019

tested on Mautix box and it works (the value does not reset to default)

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

@florentpetitjean Can you retest with last changes?
I hope new version should be much better to figure out this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.