Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact's token zero value #7641

Open
wants to merge 1 commit into
base: staging
from

Conversation

Projects
None yet
3 participants
@kuzmany
Copy link
Contributor

commented Jun 24, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? x
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7638
BC breaks?
Deprecations?

Description:

Noticed number contact type with 0 value was evaluated as empty string. This PR bring type comparison

Steps to reproduce the bug:

  1. Create a number custom field
  2. Set value of this field to zero in one contact
  3. Put your contact in a segment
  4. Create a segment email for this segment
  5. In the builder add the token of the custom field in any text bloc:
    image
  6. Send the email
  7. Open the email, the value of the token is empty
  8. Test again with any value in the custom field, you will see it in an email.

Steps to test this PR:

  1. Load up this PR
  2. Test againg nad see 0 in your email

@kuzmany kuzmany added this to the 2.16.0 milestone Jun 24, 2019

@florentpetitjean

This comment has been minimized.

Copy link

commented Jun 24, 2019

Tested and it works on mautibox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.