Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contact's token zero value #7641

Merged
merged 1 commit into from Mar 11, 2020
Merged

Fix contact's token zero value #7641

merged 1 commit into from Mar 11, 2020

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Jun 24, 2019 •
edited by npracht

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? x
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7638
BC breaks?
Deprecations?

Description:

Noticed number contact type with 0 value was evaluated as empty string. This PR bring type comparison

Steps to reproduce the bug:

  1. Create a number custom field
  2. Set value of this field to zero in one contact
  3. Put your contact in a segment
  4. Create a segment email for this segment
  5. In the builder add the token of the custom field in any text bloc:
    image
  6. Send the email
  7. Open the email, the value of the token is empty
  8. Test again with any value in the custom field, you will see it in an email.

Steps to test this PR:

  1. Load up this PR
  2. Test againg nad see 0 in your email

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Jun 24, 2019
@kuzmany kuzmany added this to the 2.16.0 milestone Jun 24, 2019
@florentpetitjean
Copy link

Tested and it works on mautibox

@npracht npracht added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Jun 24, 2019
@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Sep 1, 2019
RCheesley
RCheesley approved these changes Sep 1, 2019
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that pre-test the field was missing from emails, and post-patch the field is correctly displayed as 0.

@escopecz escopecz moved this from Ready to Test (first time) to Ready to Test (confirmation) in Mautic 2 Sep 2, 2019
@npracht npracht removed this from the 2.16.0 milestone Jan 23, 2020
@RCheesley RCheesley added this to the 2.16.1 milestone Mar 9, 2020
@npracht npracht added this to Needs a second test/review in Mautic 2 Mar 10, 2020
@RCheesley
Copy link
Sponsor Member

Going to try to close and re-open to see if it fixes the test error.

@RCheesley RCheesley closed this Mar 10, 2020
Mautic 2 automation moved this from Needs a second test/review to Merged Mar 10, 2020
@RCheesley RCheesley reopened this Mar 10, 2020
@RCheesley RCheesley added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Mar 10, 2020
@RCheesley RCheesley moved this from Merged to Ready to Commit (passed testing) in Mautic 2 Mar 10, 2020
@dennisameling dennisameling merged commit d8ec300 into mautic:staging Mar 11, 2020
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Mar 11, 2020
@mautibot
Copy link

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCheesley RCheesley RCheesley approved these changes

@florentpetitjean florentpetitjean florentpetitjean approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
Mautic 2
  
Merged
Milestone
2.16.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kuzmany @florentpetitjean @RCheesley @mautibot @npracht @dennisameling