Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7692 - typo in date format #7693

Merged
merged 1 commit into from Mar 18, 2020
Merged

Conversation

tsummerer
Copy link
Contributor

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N/A
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7692
BC breaks? N
Deprecations? N

Description:

Fixes #7692 by correcting a typo in the Date format.

Steps to reproduce the bug:

  1. See Sugarcrm Plugin - Push lead activity does not respect specified timeframe #7692

Steps to test this PR:

  1. See Sugarcrm Plugin - Push lead activity does not respect specified timeframe #7692

List deprecations along with the new alternative:

n/a

List backwards compatibility breaks:

n/a

@npracht npracht added bug Issues or PR's relating to bugs plugin Anything related to plugins ready-to-test PR's that are ready to test labels Jul 17, 2019
@npracht npracht added this to the 2.16.0 milestone Jul 17, 2019
@npracht npracht added this to Ready to Test (first time) in Mautic 2 Aug 15, 2019
@npracht npracht removed this from the 2.16.0 milestone Jan 23, 2020
@RCheesley RCheesley added this to the 2.16.1 milestone Mar 9, 2020
@npracht npracht added this to Ready to test in Mautic 2 Mar 10, 2020
@dennisameling dennisameling added the T1 Low difficulty to fix (issue) or test (PR) label Mar 18, 2020
@RCheesley
Copy link
Sponsor Member

@dennisameling does this one need more than a code review? It seems like a pretty obvious/simple fix?

Copy link
Member

@dennisameling dennisameling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes perfect sense. Thanks @tsummerer!

@dennisameling dennisameling merged commit 9515d23 into mautic:staging Mar 18, 2020
Mautic 2 automation moved this from Ready to test to Merged Mar 18, 2020
@mautibot
Copy link

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

@HN-PRO HN-PRO mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs plugin Anything related to plugins ready-to-test PR's that are ready to test T1 Low difficulty to fix (issue) or test (PR)
Projects
No open projects
Mautic 2
  
Merged
Development

Successfully merging this pull request may close these issues.

Sugarcrm Plugin - Push lead activity does not respect specified timeframe
5 participants