Fix tracking of lead that have non trackable IP #7805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npracht
added
bug
|
Please have a look at the following lines as these tests are no longer in line with the current code:
|
Woeler
added
the
pending-feedback
Woeler
removed
the
pending-feedback
Woeler
added
pending-test-confirmation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the staging branch.
Description:
Lead already identified by cookie pass through the List of IPs to not track contacts with configuration and are tracked.
Steps to reproduce the bug:
Make a web page with tracking script
Make a report on Pages: Page hits with this columns
Go to the web page on private navigation
See that anonymous contact is registred in your instance with your IP and see that one line is added to the report
Place your IP in List of IPs to not track contacts with in configuration of Mautic
Refresh the web page with tracking script, a second line is added to the report
Steps to test this PR: