fix deleteCookie expire parameter #7865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setCookie function expects a relative expirational date in seconds and does the math (time() + X) on itself. The deleteCookie function should not pass "time() - 3600", but a negative number and let setCookie do the math
npracht
added
bug
escopecz
reviewed
Oct 5, 2019
escopecz
approved these changes
Oct 7, 2019
escopecz
added
pending-test-confirmation
RCheesley
added
the
code-review-needed
dennisameling
approved these changes
Mar 18, 2020
|
This pull request has been mentioned on Mautic Community Forums. There might be relevant details there: https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setCookie function expects a relative expirational date in seconds and does the math (time() + X) on itself.
The deleteCookie function should not pass "time() - 3600", but a negative number and let setCookie do the math
Please be sure you are submitting this against the staging branch.
Description:
Steps to reproduce the bug:
Steps to test this PR:
List deprecations along with the new alternative:
List backwards compatibility breaks: