Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deleteCookie expire parameter #7865

Merged
merged 1 commit into from Mar 18, 2020
Merged

fix deleteCookie expire parameter #7865

merged 1 commit into from Mar 18, 2020

Conversation

@pety-dc
Copy link
Contributor

pety-dc commented Sep 9, 2019

The setCookie function expects a relative expirational date in seconds and does the math (time() + X) on itself.
The deleteCookie function should not pass "time() - 3600", but a negative number and let setCookie do the math

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Steps to reproduce the bug:

Steps to test this PR:

  1. Load up this PR

List deprecations along with the new alternative:

List backwards compatibility breaks:

The setCookie function expects a relative expirational date in seconds and does the math (time() + X) on itself.
The deleteCookie function should not pass "time() - 3600", but a negative number and let setCookie do the math
@npracht

This comment has been minimized.

Copy link
Member

npracht commented Oct 4, 2019

@Woeler @escopecz @kuzmany just a code review ?

@RCheesley RCheesley added this to the 2.16.1 milestone Mar 9, 2020
@npracht npracht added this to Needs a second test/review in Mautic 2 Mar 10, 2020
@RCheesley RCheesley added the L1 label Mar 18, 2020
Copy link
Member

dennisameling left a comment

Looks good. Thanks @pety-dc

@dennisameling dennisameling merged commit 4bd6795 into mautic:staging Mar 18, 2020
2 checks passed
2 checks passed
Scrutinizer Analysis: 1 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Needs a second test/review to Merged Mar 18, 2020
@mautibot

This comment has been minimized.

Copy link

mautibot commented Mar 20, 2020

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.