New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi select sync for Hubspot #7887
Fix multi select sync for Hubspot #7887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works fine now in both way.
Thanks.
@Dcoutelle I reworked it directly in Hubspot integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test the new PR and all is working.
Thanks
Hi @afonseca08 and @brendansmallco i saw you use this integration. Could you please test #7887? Your help would be highly appreciated to make it merged faster. Thanks a lot for your help! |
hey @npracht happy to test, but I cant provide my customer's actual hubspot API creds. Is there a test instance? p.s. ive replaced my own sandbox instance with the new test HubspotIntegration.php and MySQL is still throwing errors - Hubspot is providing a millisecond timestamp - SQL isnt quite liking it - Logs: [2019-10-07 09:39:53] mautic.WARNING: An exception occurred while executing 'UPDATE ma_leads SET persona = ?, persona_orientation = ?, product_segment = ?, lead_create_date = ?, hubspot_source = ? WHERE id = ?' with params ["persona_8", "Data Orientated (Revenue)", "Spray", "1568857151139", "OFFLINE", 32]: SQLSTATE[22007]: Invalid datetime format: 1292 Incorrect datetime value: '1568857151139' for column 'lead_create_date' at row 1 [] [] |
This issue is not fixing date/time field. Please unmap this field for the test and just try to sync. multiselect field (this is what is supposed to be fixed by this PR). |
Thanks @npracht - unmapped the field, synced and it appears to be working. Multiselect field is coming through. If you have any hints for me about where the code for timestamp handling is that would be handy! |
Hi @kuzmany can you check if your PR is mergeable in https://github.com/mautic/mautic/tree/3.x and manage conflicts if needed? |
Please be sure you are submitting this against the staging branch.
Description:
Fix for both way sync multi select field for Hubspot integration
Steps to reproduce the bug:
1 Create a custom multiple field in Mautic
2 Create a custom multiple field in Hubspot with the same exact choices as in Mautic
3 Create a contact in Mautic with at least 2 choices in the multiple field and push it in Hubspot with a form
4 See that in Hubspot the multiple field is empty
5 Create a contact in Hubspot and synchronize it with cron to Mautic.
6 See that in Mautic the multiple field is empty
Steps to test this PR:
List deprecations along with the new alternative:
List backwards compatibility breaks: