Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added z-index for section action buttons #7906

Merged
merged 1 commit into from Jan 28, 2020
Merged

Added z-index for section action buttons #7906

merged 1 commit into from Jan 28, 2020

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Oct 1, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

I noticed for some template cannot work with section action because, because was covered text slot part. This PR fixed it

image

Steps to test this PR:

  1. Load up this PR
  2. Should code review is enought

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 1, 2019
@kuzmany kuzmany added this to the 2.16.0 milestone Oct 1, 2019
@npracht npracht added this to Ready to Test (first time) in Mautic 2 Oct 3, 2019
npracht
npracht approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@npracht npracht added T1 Low difficulty to fix (issue) or test (PR) pending-test-confirmation PR's that require one test before they can be merged user-interface Anything related to appearance, layout, and interactivity and removed ready-to-test PR's that are ready to test labels Oct 4, 2019
@npracht npracht moved this from Ready to Test (first time) to Ready to Test (confirmation) in Mautic 2 Oct 9, 2019
@tiangao88
Copy link

tested and works well

@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Oct 9, 2019
@npracht npracht moved this from Ready to Test (confirmation) to Ready to Commit (passed testing) in Mautic 2 Oct 9, 2019
@npracht
Copy link
Member

npracht commented Jan 20, 2020

Hi @kuzmany can you check if your PR is mergeable in https://github.com/mautic/mautic/tree/3.x and manage conflicts if needed?
Then we give a chance to the PR to be merged in 3.0.0. Thanks !

@npracht npracht modified the milestones: 2.16.0, 2.15.4 Jan 23, 2020
@dennisameling dennisameling merged commit 9f6eccb into mautic:staging Jan 28, 2020
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Jan 28, 2020
@dennisameling dennisameling removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity
Projects
No open projects
Mautic 2
  
Merged
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuzmany @tiangao88 @npracht @dennisameling