Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preference_center.tooltip to landing page PageType #7915

Merged
merged 4 commits into from Jan 28, 2020
Merged

Add preference_center.tooltip to landing page PageType #7915

merged 4 commits into from Jan 28, 2020

Conversation

virgilwashere
Copy link
Contributor

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Add preference_center.tooltip to landing page PageType

Steps to reproduce the bug:

  1. Create or edit a landing page.
  2. Notice the lack of ❔ and tooltip.
    image

Steps to test this PR:

  1. Load up this PR
  2. Create or edit a landing page.
  3. See the ❔ icon and tooltip for the preference center yes/no button.
    image

@virgilwashere
Add preference_center.tooltip to Landing Page
d40c8be
@virgilwashere
Rename preference page identifer to match
a9e6651 
From `mautic.page.config.preference_center`
to `mautic.page.form.preference_center`

which brings it inline with the other fields on the page

- `mautic.page.form.customhtml`
- `mautic.page.form.template`
- `mautic.page.form.metadescription`
- `mautic.page.form.redirecttype`
- `mautic.page.form.redirecturl`

and `mautic.email.form.preference_center`, which is the only other
preference center message.
@virgilwashere
Rephrase preference center tooltip content
c276691
@mautibot
Copy link

mautibot commented Oct 3, 2019

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/what-is-preference-center/10501/3

@npracht npracht added enhancement Any improvement to an existing feature or functionality user-interface Anything related to appearance, layout, and interactivity labels Oct 3, 2019
@npracht
Update messages.ini
e8722f0 
2 spaces instead of one
npracht
npracht approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@npracht npracht added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Oct 3, 2019
@npracht npracht added this to the 2.16.0 milestone Oct 3, 2019
@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Oct 3, 2019
@npracht npracht moved this from Ready to Test (confirmation) to Ready to Commit (passed testing) in Mautic 2 Oct 3, 2019
@npracht npracht modified the milestone: 2.16.0 Jan 23, 2020
@dennisameling dennisameling merged commit d95ea1a into mautic:staging Jan 28, 2020
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Jan 28, 2020
@dennisameling dennisameling removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
enhancement Any improvement to an existing feature or functionality user-interface Anything related to appearance, layout, and interactivity
Projects
No open projects
Mautic 2
  
Merged
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@virgilwashere @mautibot @npracht @dennisameling