Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clone campaign with segment/form sources #7934

Merged
merged 1 commit into from Mar 11, 2020
Merged

Fix clone campaign with segment/form sources #7934

merged 1 commit into from Mar 11, 2020

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Oct 9, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR fixed ugly issue If using both sources of campaign - segments and form.

Steps to reproduce the bug:

  1. Create campaign with segment source and form source (yes Mautic support it)
    image
  2. Clone campaign (don't save)
  3. Open campaign builder
  4. Edit segment source and change segment
  5. Then try apply
  6. See your form source was removed
    image

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps and see if both sources (segments/forms) are update properly

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 9, 2019
@kuzmany kuzmany added this to the 2.16.0 milestone Oct 9, 2019
@npracht npracht added the T1 Low difficulty to fix (issue) or test (PR) label Oct 9, 2019
@tiangao88
Copy link

works as described!

@npracht npracht added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Oct 9, 2019
@npracht npracht removed this from the 2.16.0 milestone Jan 23, 2020
@RCheesley RCheesley added this to the 2.16.1 milestone Mar 9, 2020
@npracht npracht added this to Needs a second test/review in Mautic 2 Mar 10, 2020
RCheesley
RCheesley approved these changes Mar 10, 2020
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually had no idea this functionality existed so thank you for enlightening me!

Tested with Mautibox and was able to change the segment in the cloned campaign without losing the form.

@RCheesley RCheesley added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Mar 10, 2020
@RCheesley RCheesley moved this from Needs a second test/review to Ready to Commit (passed testing) in Mautic 2 Mar 10, 2020
@dennisameling dennisameling merged commit 9eca7f7 into mautic:staging Mar 11, 2020
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Mar 11, 2020
@mautibot
Copy link

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCheesley RCheesley RCheesley approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR)
Projects
No open projects
Mautic 2
  
Merged
Milestone
2.16.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kuzmany @tiangao88 @mautibot @RCheesley @npracht @dennisameling