Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clone campaign with segment/form sources #7934

Open
wants to merge 1 commit into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Oct 9, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR fixed ugly issue If using both sources of campaign - segments and form.

Steps to reproduce the bug:

  1. Create campaign with segment source and form source (yes Mautic support it)
    image
  2. Clone campaign (don't save)
  3. Open campaign builder
  4. Edit segment source and change segment
  5. Then try apply
  6. See your form source was removed
    image

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps and see if both sources (segments/forms) are update properly
@kuzmany kuzmany added this to the 2.16.0 milestone Oct 9, 2019
@npracht npracht added the L1 label Oct 9, 2019
@tiangao88

This comment has been minimized.

Copy link

tiangao88 commented Oct 9, 2019

works as described!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.