Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix on CommonRepository #8033

Merged
merged 1 commit into from Jan 29, 2020
Merged

Bug fix on CommonRepository #8033

merged 1 commit into from Jan 29, 2020

Conversation

bookin
Copy link
Contributor

@bookin bookin commented Oct 28, 2019

When you try use in or notIn code also rund default block in the swith:case

@bookin
Bug fix on CommonRepository
dcefd26 
When you try use `in` or `notIn` code also rund `default` block in the `swith:case`
@npracht npracht added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 29, 2019
@npracht
Copy link
Member

npracht commented Oct 29, 2019

@kuzmany or @escopecz just a code review must be enough :)

kuzmany
kuzmany approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

kuzmany
kuzmany approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

escopecz
escopecz approved these changes Oct 29, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test labels Oct 29, 2019
@npracht npracht added this to the 2.16.0 milestone Oct 29, 2019
@npracht npracht added this to Ready to Commit (passed testing) in Mautic 2 Oct 29, 2019
@npracht npracht modified the milestones: 2.16.0, 2.15.4 Jan 23, 2020
@dennisameling dennisameling merged commit 815de70 into mautic:staging Jan 29, 2020
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Jan 29, 2020
@dennisameling dennisameling removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs
Projects
No open projects
Mautic 2
  
Merged
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bookin @npracht @kuzmany @escopecz @dennisameling