Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade report bundle to work with Symfony 3 forms #8056

Merged
merged 7 commits into from Dec 13, 2019
Merged

Upgrade report bundle to work with Symfony 3 forms #8056

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c3d7cb8
Upgrade report bundle to work with Symfony 3 forms
dongilbert Nov 1, 2019
15f51d1
Remove MauticFactory
dongilbert Nov 1, 2019
820864d
Typehint the TranslatorInterface instead
dongilbert Nov 1, 2019
ee3b811
Flip labels with values for choice types
escopecz Dec 13, 2019
6d591b7
Use class names instead of form aliases
escopecz Dec 13, 2019
ed17e4f
This is how a config form should be registered now
escopecz Dec 13, 2019
f048c1d
Merge branch 'm2-to-m3' into GIT-7989.report-bundle-upgrade
escopecz Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 6 additions & 12 deletions app/bundles/ReportBundle/Config/config.php
View file
Open in desktop
Expand Up @@ -116,7 +116,6 @@
'forms' => [
'mautic.form.type.reportconfig' => [
'class' => \Mautic\ReportBundle\Form\Type\ConfigType::class,
'alias' => 'reportconfig',
],
'mautic.form.type.report' => [
'class' => \Mautic\ReportBundle\Form\Type\ReportType::class,
Expand All @@ -126,36 +125,31 @@
],
],
'mautic.form.type.filter_selector' => [
'class' => 'Mautic\ReportBundle\Form\Type\FilterSelectorType',
'alias' => 'filter_selector',
'class' => \Mautic\ReportBundle\Form\Type\FilterSelectorType::class,
],
'mautic.form.type.table_order' => [
'class' => 'Mautic\ReportBundle\Form\Type\TableOrderType',
'arguments' => 'mautic.factory',
'alias' => 'table_order',
'class' => \Mautic\ReportBundle\Form\Type\TableOrderType::class,
'arguments' => [
'translator',
],
],
'mautic.form.type.report_filters' => [
'class' => 'Mautic\ReportBundle\Form\Type\ReportFiltersType',
'arguments' => 'mautic.factory',
'alias' => 'report_filters',
],
'mautic.form.type.report_dynamic_filters' => [
'class' => 'Mautic\ReportBundle\Form\Type\DynamicFiltersType',
'alias' => 'report_dynamicfilters',
],
'mautic.form.type.report_widget' => [
'class' => 'Mautic\ReportBundle\Form\Type\ReportWidgetType',
'alias' => 'report_widget',
'arguments' => 'mautic.report.model.report',
],
'mautic.form.type.aggregator' => [
'class' => 'Mautic\ReportBundle\Form\Type\AggregatorType',
'alias' => 'aggregator',
'class' => \Mautic\ReportBundle\Form\Type\AggregatorType::class,
'arguments' => 'translator',
],
'mautic.form.type.report.settings' => [
'class' => \Mautic\ReportBundle\Form\Type\ReportSettingsType::class,
'alias' => 'report_settings',
],
],
'helpers' => [
Expand Down
3 changes: 2 additions & 1 deletion app/bundles/ReportBundle/Controller/ReportController.php
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@
use Mautic\CoreBundle\Helper\DateTimeHelper;
use Mautic\CoreBundle\Helper\InputHelper;
use Mautic\ReportBundle\Entity\Report;
use Mautic\ReportBundle\Form\Type\DynamicFiltersType;
use Mautic\ReportBundle\Model\ExportResponse;
use Symfony\Component\HttpFoundation;

Expand Down Expand Up @@ -645,7 +646,7 @@ public function viewAction($objectId, $reportPage = 1)
}

$dynamicFilterForm = $this->get('form.factory')->create(
'report_dynamicfilters',
DynamicFiltersType::class,
$filterSettings,
[
'action' => $action,
Expand Down
5 changes: 4 additions & 1 deletion app/bundles/ReportBundle/Form/DataTransformer/ReportFilterDataTransformer.php
View file
Open in desktop
Expand Up @@ -13,6 +13,9 @@

use Mautic\CoreBundle\Helper\DateTimeHelper;
use Symfony\Component\Form\DataTransformerInterface;
use Symfony\Component\Form\Extension\Core\Type\DateTimeType;
use Symfony\Component\Form\Extension\Core\Type\DateType;
use Symfony\Component\Form\Extension\Core\Type\TimeType;

class ReportFilterDataTransformer implements DataTransformerInterface
{
Expand Down Expand Up @@ -46,7 +49,7 @@ public function transform($filters)
return $filters;
}
$type = $this->columns[$f['column']]['type'];
if (in_array($type, ['datetime', 'date', 'time'])) {
if (in_array($type, ['datetime', 'date', 'time', DateTimeType::class, DateType::class, TimeType::class])) {
$dt = new DateTimeHelper($f['value'], '', 'utc');
$f['value'] = $dt->toLocalString();
}
Expand Down
17 changes: 11 additions & 6 deletions app/bundles/ReportBundle/Form/Type/AggregatorType.php
View file
Open in desktop
Expand Up @@ -12,19 +12,24 @@
namespace Mautic\ReportBundle\Form\Type;

use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Form\FormView;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\Component\Translation\TranslatorInterface;

/**
* Class AggregatorType.
*/
class AggregatorType extends AbstractType
{
/**
* @var TranslatorInterface
*/
private $translator;

public function __construct($translator)
public function __construct(TranslatorInterface $translator)
{
$this->translator = $translator;
}
Expand All @@ -35,7 +40,7 @@ public function __construct($translator)
public function buildForm(FormBuilderInterface $builder, array $options)
{
// function
$builder->add('function', 'choice', [
$builder->add('function', ChoiceType::class, [
'choices' => [
'COUNT' => $this->translator->trans('mautic.report.report.label.aggregators.count'),
'AVG' => $this->translator->trans('mautic.report.report.label.aggregators.avg'),
Expand All @@ -55,7 +60,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
]);

// Build a list of columns
$builder->add('column', 'choice', [
$builder->add('column', ChoiceType::class, [
'choices' => $options['columnList'],
'expanded' => false,
'multiple' => false,
Expand All @@ -82,15 +87,15 @@ public function buildView(FormView $view, FormInterface $form, array $options)
/**
* {@inheritdoc}
*/
public function getName()
public function getBlockPrefix()
{
return 'aggregator';
}

/**
* {@inheritdoc}
*/
public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults([
'columnList' => [],
Expand Down
2 changes: 1 addition & 1 deletion app/bundles/ReportBundle/Form/Type/ConfigType.php
View file
Open in desktop
Expand Up @@ -43,7 +43,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
/**
* {@inheritdoc}
*/
public function getName()
public function getBlockPrefix()
{
return 'reportconfig';
}
Expand Down
21 changes: 13 additions & 8 deletions app/bundles/ReportBundle/Form/Type/DynamicFiltersType.php
View file
Open in desktop
Expand Up @@ -11,10 +11,15 @@

namespace Mautic\ReportBundle\Form\Type;

use Mautic\CoreBundle\Form\Type\ButtonGroupType;
use Mautic\ReportBundle\Entity\Report;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
use Symfony\Component\Form\Extension\Core\Type\DateTimeType;
use Symfony\Component\Form\Extension\Core\Type\DateType;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
* Class DynamicFiltersType.
Expand Down Expand Up @@ -43,7 +48,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
switch ($definition['type']) {
case 'bool':
case 'boolean':
$type = 'button_group';
$type = ButtonGroupType::class;
$args['choices_as_values'] = true;
$args['choices'] = [
[
Expand All @@ -60,26 +65,26 @@ public function buildForm(FormBuilderInterface $builder, array $options)
}
break;
case 'date':
$type = 'date';
$type = DateType::class;
$args['input'] = 'string';
$args['widget'] = 'single_text';
$args['format'] = 'y-MM-dd';
$args['attr']['class'] .= ' datepicker';
break;
case 'datetime':
$type = 'datetime';
$type = DateTimeType::class;
$args['input'] = 'string';
$args['widget'] = 'single_text';
$args['format'] = 'y-MM-dd HH:mm:ss';
$args['attr']['class'] .= ' datetimepicker';
break;
case 'multiselect':
case 'select':
$type = 'choice';
$type = ChoiceType::class;
$args['choices'] = $definition['list'];
break;
default:
$type = 'text';
$type = TextType::class;
break;
}

Expand All @@ -91,15 +96,15 @@ public function buildForm(FormBuilderInterface $builder, array $options)
/**
* {@inheritdoc}
*/
public function getName()
public function getBlockPrefix()
{
return 'report_dynamicfilters';
}

/**
* {@inheritdoc}
*/
public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(
[
Expand Down
16 changes: 9 additions & 7 deletions app/bundles/ReportBundle/Form/Type/FilterSelectorType.php
View file
Open in desktop
Expand Up @@ -11,14 +11,16 @@

namespace Mautic\ReportBundle\Form\Type;

use Mautic\CoreBundle\Form\Type\YesNoButtonGroupType;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormEvent;
use Symfony\Component\Form\FormEvents;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Form\FormView;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
* Class FilterSelectorType.
Expand All @@ -33,7 +35,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
// Build a list of columns
$builder->add(
'column',
'choice',
ChoiceType::class,
[
'choices' => $options['filterList'],
'expanded' => false,
Expand All @@ -58,7 +60,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
// Build a list of condition values
$form->add(
'condition',
'choice',
ChoiceType::class,
[
'choices' => $choices,
'expanded' => false,
Expand Down Expand Up @@ -108,7 +110,7 @@ function (FormEvent $event) use ($formModifier) {

$builder->add(
'value',
'text',
TextType::class,
[
'label' => 'mautic.report.report.label.filtervalue',
'label_attr' => ['class' => 'control-label'],
Expand All @@ -119,7 +121,7 @@ function (FormEvent $event) use ($formModifier) {

$builder->add(
'dynamic',
'yesno_button_group',
YesNoButtonGroupType::class,
[
'label' => 'mautic.report.report.label.filterdynamic',
'label_attr' => ['class' => 'control-label'],
Expand Down Expand Up @@ -148,15 +150,15 @@ public function buildView(FormView $view, FormInterface $form, array $options)
/**
* {@inheritdoc}
*/
public function getName()
public function getBlockPrefix()
{
return 'filter_selector';
}

/**
* {@inheritdoc}
*/
public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(
[
Expand Down
9 changes: 5 additions & 4 deletions app/bundles/ReportBundle/Form/Type/ReportFiltersType.php
View file
Open in desktop
Expand Up @@ -13,8 +13,9 @@

use Mautic\ReportBundle\Form\DataTransformer\ReportFilterDataTransformer;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\CollectionType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
* Class ReportFiltersType.
Expand All @@ -34,7 +35,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
/**
* {@inheritdoc}
*/
public function getName()
public function getBlockPrefix()
{
return 'report_filters';
}
Expand All @@ -44,13 +45,13 @@ public function getName()
*/
public function getParent()
{
return 'collection';
return CollectionType::class;
}

/**
* {@inheritdoc}
*/
public function setDefaultOptions(OptionsResolverInterface $resolver)
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults(
[
Expand Down
9 changes: 5 additions & 4 deletions app/bundles/ReportBundle/Form/Type/ReportSettingsType.php
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@

namespace Mautic\ReportBundle\Form\Type;

use Mautic\CoreBundle\Form\Type\YesNoButtonGroupType;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;

Expand All @@ -27,7 +28,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
{
$builder->add(
'showGraphsAboveTable',
'yesno_button_group',
YesNoButtonGroupType::class,
[
'label' => 'mautic.report.report.form.display.graphs.above.table',
'attr' => [
Expand All @@ -39,7 +40,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)

$builder->add(
'showDynamicFilters',
'yesno_button_group',
YesNoButtonGroupType::class,
[
'label' => 'mautic.report.report.form.display.show.dynamic.filters',
'attr' => [
Expand All @@ -51,7 +52,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)

$builder->add(
'hideDateRangeFilter',
'yesno_button_group',
YesNoButtonGroupType::class,
[
'label' => 'mautic.report.report.form.display.hide.date.ranges',
'attr' => [
Expand All @@ -65,7 +66,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
/**
* @return string
*/
public function getName()
public function getBlockPrefix()
{
return 'report_settings';
}
Expand Down