M3: Refactor Deprecations - ApiBundle #7985

[mtshaw3]

PR for #7985

• Remove uses of MauticFactory
• Search for and remove/refactor M2 @deprecated code if simple otherwise, create a new issue with details to be prioritized
• https://github.com/symfony/symfony/blob/3.0/UPGRADE-3.0.md#form

ApiBundle/Form/Validator/Constraints/OAuthCallbackValidator.php

• Nr. 350 line 52: Calling deprecated method Symfony\Component\Validator\ConstraintValidator->buildViolation() - NOTE: This one is confusing because all though it is marked deprecated in the code, the Symfony 3.0 upgrade doc says to use it????

ApiBundle/Form/Type/ClientType.php

• Nr. 351 line 267: Using deprecated interface Symfony\Component\OptionsResolver\OptionsResolverInterface
• Nr. 352 line 267: Overriding deprecated method Mautic\ApiBundle\Form\Type\ClientType->setDefaultOptions()
• Nr. 353 line 280: Overriding deprecated method Mautic\ApiBundle\Form\Type\ClientType->getName()

ApiBundle/Form/Type/ConfigType.php

• Nr. 354 line 117: Overriding deprecated method Mautic\ApiBundle\Form\Type\ConfigType->getName()

[escopecz]

@mtshaw3 check the Travis CI

[anton-vlasenko]

@mtshaw3 We are building a form in Mautic\ApiBundle\Form\Type\ConfigType.
Could you please pass fully qualified class name (FQCN) to the add method as described here:
https://github.com/symfony/symfony/blob/3.0/UPGRADE-3.0.md#form ?
Same thing applies for Mautic\ApiBundle\Form\Type\ClientType class.

[anton-vlasenko]

I wonder how to test this. Do you have any ideas? :)
It's not practically possible to test every api call. I'm going to test only couple of them.
Is there anything else that I have to pay attention to?

[anton-vlasenko]

I wonder how to test this. Do you have any ideas? :)
It's not practically possible to test every api call. I'm going to test only couple of them.
Is there anything else that I have to pay attention to?

@mtshaw3 I think that's a brilliant idea of yours to test API bundle using our api library tests.
I will do it.

[dongilbert]

Tried testing with the API-Library. Every endpoint is giving me a 404 error. I've ensured the API is enabled, and I'm using HTTP Basic Auth.

[dongilbert]

Was able to get the API library tests running - will post results when they finish

[anton-vlasenko]

The code looks fine.
I've tested this and the unit tests showed no new errors.
Therefore I approve this PR.

[anton-vlasenko]

@dongilbert Would you like to add your own review?
If not, please let me know so I could close this PR.