Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3: Remove deprecations from WebhookBundle #8061

Merged
merged 25 commits into from Nov 28, 2019
Merged

M3: Remove deprecations from WebhookBundle #8061

merged 25 commits into from Nov 28, 2019

Conversation

hluchas
Copy link
Contributor

@hluchas hluchas commented Nov 1, 2019 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7990
BC breaks? Yes
Deprecations?

Description:

Remove deprected code from WebhookBundle

Steps to test this PR:

  1. Load up this PR
  2. Use form to create/edit webhook and make sure it's working as before
  3. Use defined webhook and make sure that requests are filling log
  4. Use webhook in campaign action

List backwards compatibility breaks:

  1. Removed class Mautic\WebhookBundle\EventListener\WebhookSubscriberBase
  2. & not used for first parameter in constructor anymore in \Mautic\WebhookBundle\Event\WebhookEvent
  3. Mautic\WebhookBundle\Model\WebhookModel::webhookStart (protected property)
  4. \Mautic\WebhookBundle\Form\Type\WebhookType doesn't use translator in constructor
  5. Removed WebhookBundle\EventListener\WebhookModelTrait

@hluchas hluchas changed the title Webhook bundle upgrade Remove deprecations from WebhookBundle Nov 1, 2019
@hluchas hluchas added this to the 3.0.0 milestone Nov 1, 2019
@npracht npracht added code-review-needed PR's that require a code review before merging T2 Medium difficulty to fix (issue) or test (PR) ready-to-test PR's that are ready to test labels Nov 1, 2019
@escopecz
Copy link
Sponsor Member

escopecz commented Nov 1, 2019

@hluchas check Travis errors

@hluchas hluchas mentioned this pull request Nov 2, 2019
Closed
6 tasks
@hluchas hluchas changed the title Remove deprecations from WebhookBundle M3: Remove deprecations from WebhookBundle Nov 4, 2019
@hluchas hluchas requested a review from escopecz November 5, 2019 09:49
escopecz
escopecz approved these changes Nov 5, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks! 👍

@escopecz escopecz removed the code-review-needed PR's that require a code review before merging label Nov 5, 2019
@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Nov 21, 2019
@escopecz escopecz removed the pending-feedback PR's and issues that are awaiting feedback from the author label Nov 28, 2019
@escopecz
Copy link
Sponsor Member

If I try to open the campaign webhook action form I get Could not load type "sortablelist": class does not exist.

@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Nov 28, 2019
@hluchas
Copy link
Contributor Author

hluchas commented Nov 28, 2019

If I try to open the campaign webhook action form I get Could not load type "sortablelist": class does not exist.

Fixed

@escopecz escopecz removed the pending-feedback PR's and issues that are awaiting feedback from the author label Nov 28, 2019
escopecz
escopecz approved these changes Nov 28, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All webhook forms work for me 👍

@escopecz escopecz removed the ready-to-test PR's that are ready to test label Nov 28, 2019
@hluchas
Copy link
Contributor Author

hluchas commented Nov 28, 2019

All webhook forms work for me 👍

TY John!

@escopecz escopecz merged commit 64ee11b into mautic:m2-to-m3 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
T2 Medium difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hluchas @escopecz @npracht