Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard bundle deprecation refactoring #8065

Merged
merged 2 commits into from Nov 21, 2019
Merged

Dashboard bundle deprecation refactoring #8065

merged 2 commits into from Nov 21, 2019

Conversation

Enc3phale
Copy link
Contributor

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? N
New feature? Y
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) #7993
BC breaks? N
Deprecations? N

Description:

This PR upgrades DashboardBundle Symfony Form types to work with Symfony 3.

Steps to test this PR:

  1. On Dashboard try :
  • to add widget
  • to export dashboard
  • to import dashboard

@Enc3phale Enc3phale added this to the 3.0.0 milestone Nov 1, 2019
@Enc3phale Enc3phale changed the base branch from staging to m2-to-m3 November 1, 2019 15:36
@npracht npracht added code-review-needed PR's that require a code review before merging Mautic 3 ready-to-test PR's that are ready to test labels Nov 1, 2019
npracht
npracht approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What i tested and everything worked 🍾 !

  • Add
  • Remove
  • All the type of widgets
  • Edit all and existing natives
  • Export
  • Import

@npracht npracht added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Nov 1, 2019
escopecz
escopecz approved these changes Nov 4, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problem in the code. Great work! 👍

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged labels Nov 4, 2019
@escopecz escopecz merged commit d41a8b0 into mautic:m2-to-m3 Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enc3phale @escopecz @npracht