Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecations from Clearbit bundle and make it compatible with Symfony 3 #8072

Merged
merged 7 commits into from Nov 25, 2019
Merged

Remove deprecations from Clearbit bundle and make it compatible with Symfony 3 #8072

merged 7 commits into from Nov 25, 2019

Conversation

anton-vlasenko
Copy link
Contributor

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8010
BC breaks?
Deprecations?

Description:

This PR upgrades Clearbit bundle so it's compatible with Symfony 3.

Steps to test this PR:

  1. Load up this PR
  2. Go to plugins page, enable Clearbit plugin, enter API credentials.
  3. Try to lookup contact information as described here: https://www.mautic.org/docs/en/plugins/clearbit.html

@anton-vlasenko anton-vlasenko added this to the 3.0.0 milestone Nov 1, 2019
@anton-vlasenko anton-vlasenko mentioned this pull request Nov 1, 2019
Closed
5 tasks
@anton-vlasenko anton-vlasenko added the code-review-needed PR's that require a code review before merging label Nov 1, 2019
@npracht npracht added plugin Anything related to plugins ready-to-test PR's that are ready to test labels Nov 1, 2019
escopecz
escopecz requested changes Nov 1, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove form aliases from config.php

plugins/MauticClearbitBundle/Form/Type/BatchLookupType.php Outdated Show resolved Hide resolved
plugins/MauticClearbitBundle/Form/Type/BatchLookupType.php Show resolved Hide resolved
plugins/MauticClearbitBundle/Form/Type/LookupType.php Outdated Show resolved Hide resolved
escopecz
escopecz approved these changes Nov 2, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems. Nice! 👍

@escopecz escopecz removed the code-review-needed PR's that require a code review before merging label Nov 2, 2019
@escopecz
Copy link
Sponsor Member

Tested, works correctly. 👍

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test labels Nov 25, 2019
@escopecz escopecz merged commit e6bbf2f into mautic:m2-to-m3 Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
plugin Anything related to plugins ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anton-vlasenko @escopecz @npracht