Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3: Refactor Deprecations - MauticFocusBundle #8089

Open
wants to merge 5 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Nov 2, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8012
BC breaks?
Deprecations?

Description:

Steps to test this PR:

  1. Load up this PR
  2. Try create/edit focuss
  3. Insert focus js in your page
@kuzmany kuzmany added the WIP label Nov 2, 2019
kuzmany added 2 commits Nov 2, 2019
@kuzmany kuzmany added Mautic 3 Ready To Test and removed WIP labels Nov 2, 2019
@npracht npracht added this to the 3.0.0 milestone Nov 3, 2019
@npracht npracht added the Code Review label Nov 3, 2019
Copy link
Member

npracht left a comment

Not working

When I try to go to Channels > Focus, I directly have this issue
Capture d’écran 2019-11-04 à 16 39 57

[2019-11-04 15:39:53] mautic.CRITICAL: Uncaught PHP Exception Symfony\Component\Debug\Exception\UndefinedMethodException: "Attempted to call an undefined method named "setStandardParameters" of class "MauticPlugin\MauticFocusBundle\Controller\FocusController"." at /var/app/current/code/pulls/8089/plugins/MauticFocusBundle/Controller/FocusController.php line 29 {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\UndefinedMethodException(code: 0): Attempted to call an undefined method named \"setStandardParameters\" of class \"MauticPlugin\\MauticFocusBundle\\Controller\\FocusController\". at /var/app/current/code/pulls/8089/plugins/MauticFocusBundle/Controller/FocusController.php:29)
[stacktrace]
#0 /var/app/current/code/pulls/8089/vendor/symfony/http-kernel/Controller/ControllerResolver.php(187): MauticPlugin\\MauticFocusBundle\\Controller\\FocusController->__construct()
#1 /var/app/current/code/pulls/8089/vendor/symfony/framework-bundle/Controller/ControllerResolver.php(76): Symfony\\Component\\HttpKernel\\Controller\\ControllerResolver->instantiateController('MauticPlugin\\\\Ma...')
#2 /var/app/current/code/pulls/8089/vendor/symfony/http-kernel/Controller/ControllerResolver.php(175): Symfony\\Bundle\\FrameworkBundle\\Controller\\ControllerResolver->instantiateController('MauticPlugin\\\\Ma...')
#3 /var/app/current/code/pulls/8089/vendor/symfony/framework-bundle/Controller/ControllerResolver.php(64): Symfony\\Component\\HttpKernel\\Controller\\ControllerResolver->createController('MauticPlugin\\\\Ma...')
#4 /var/app/current/code/pulls/8089/vendor/symfony/http-kernel/Controller/ControllerResolver.php(88): Symfony\\Bundle\\FrameworkBundle\\Controller\\ControllerResolver->createController('MauticPlugin\\\\Ma...')
#5 /var/app/current/code/pulls/8089/vendor/symfony/http-kernel/Controller/TraceableControllerResolver.php(38): Symfony\\Component\\HttpKernel\\Controller\\ControllerResolver->getController(Object(Symfony\\Component\\HttpFoundation\\Request))
#6 /var/app/current/code/pulls/8089/vendor/symfony/http-kernel/HttpKernel.php(123): Symfony\\Component\\HttpKernel\\Controller\\TraceableControllerResolver->getController(Object(Symfony\\Component\\HttpFoundation\\Request))
#7 /var/app/current/code/pulls/8089/vendor/symfony/http-kernel/HttpKernel.php(57): Symfony\\Component\\HttpKernel\\HttpKernel->handleRaw(Object(Symfony\\Component\\HttpFoundation\\Request), 1)
#8 /var/app/current/code/pulls/8089/vendor/symfony/http-kernel/DependencyInjection/ContainerAwareHttpKernel.php(67): Symfony\\Component\\HttpKernel\\HttpKernel->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#9 /var/app/current/code/pulls/8089/vendor/symfony/http-kernel/Kernel.php(183): Symfony\\Component\\HttpKernel\\DependencyInjection\\ContainerAwareHttpKernel->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#10 /var/app/current/code/pulls/8089/app/AppKernel.php(141): Symfony\\Component\\HttpKernel\\Kernel->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#11 /var/app/current/code/pulls/8089/app/middlewares/CORSMiddleware.php(93): AppKernel->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#12 /var/app/current/code/pulls/8089/app/middlewares/CatchExceptionMiddleware.php(45): Mautic\\Middleware\\CORSMiddleware->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#13 /var/app/current/code/pulls/8089/app/middlewares/Dev/IpRestrictMiddleware.php(55): Mautic\\Middleware\\CatchExceptionMiddleware->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#14 /var/app/current/code/pulls/8089/app/middlewares/VersionCheckMiddleware.php(57): Mautic\\Middleware\\Dev\\IpRestrictMiddleware->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#15 /var/app/current/code/pulls/8089/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Mautic\\Middleware\\VersionCheckMiddleware->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#16 /var/app/current/code/pulls/8089/vendor/stack/run/src/Stack/run.php(13): Stack\\StackedHttpKernel->handle(Object(Symfony\\Component\\HttpFoundation\\Request))
#17 /var/app/current/code/pulls/8089/index_dev.php(33): Stack\
un(Object(Stack\\StackedHttpKernel))
#18 /var/app/current/code/pulls/8089/index.php(6): require_once('/var/app/curren...')
#19 {main}
"} 

⚠️ Mautibox is in dev mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.