Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor deprecated code in CoreBundle #8104

Merged
merged 76 commits into from Nov 26, 2019
Merged

Refactor deprecated code in CoreBundle #8104

merged 76 commits into from Nov 26, 2019

Conversation

alanhartless
Copy link
Contributor

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature? y
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8004
BC breaks?
Deprecations?

Description:

This PR removes a lot of deprecated code from the core bundle (see the commit list). It touches almost every part of Mautic. Testing simply includes navigating and using the basic functions of Mautic to ensure continued support.

It touches but not an exhaustive list :-)

  1. Nearly every form
  2. Dashboard widget caching
  3. Permissions for the focus plugin and social plugin
  4. Menu
  5. Dev asset generation
  6. Loading translations
  7. Email and page builder tokens

@alanhartless alanhartless added this to the 3.0.0 milestone Nov 5, 2019
@dongilbert dongilbert changed the base branch from staging to m2-to-m3 November 5, 2019 16:11
@alanhartless @escopecz
Removed alias from form extension
b3963c6
@alanhartless @escopecz
Update use of getParent to be a FQNS
9dbbcf5
@alanhartless @escopecz
Changed button_group to ButtonGroupType::class
87abe76
@alanhartless @escopecz
Changed ButtonGroupType from setDefaults to configureOptions
fc77653
@alanhartless @escopecz
Add back getName as getBlockPrefix
3f1ffb6
@alanhartless @escopecz
Change slot_imagecaption to SlotImageCaptionType
f644f90
@alanhartless @escopecz
Change spacer to SpacerType
d520b90
@alanhartless @escopecz
Change slot_button to SlotButtonType
f5a64ed
@alanhartless @escopecz
Remove deprecated ChoiceList
d63a03c
@alanhartless @escopecz
Removed spacer and hidden_entity form types that are not used
0b0a53f
@alanhartless @escopecz
Missed a couple group_button
b6ef6ea
@alanhartless @escopecz
Refactored theme_list to ThemeListType
2a4e6bd
@alanhartless @escopecz
Refactored sortablelist to SortableListType
9820f74
@alanhartless @escopecz
Refactored form_buttons to FormButtonsType
abf152c
@alanhartless @escopecz
Refactored theme_upload to ThemeUploadType
4ad5cac
@alanhartless @escopecz
Refactored slot_successmessage to SlotSuccessMessageType
b1a9d9b
@alanhartless @escopecz
Refactored daterange to DateRangeType
97f5623
@alanhartless @escopecz
Refactored coreconfig to ConfigType
f46dd21
@alanhartless @escopecz
Refactored slot_socialshare to SlotSocialShareType
97266ff
@alanhartless @escopecz
Refactored dynamic_content_filter to DynamicContentFilterType
e926423
@alanhartless @escopecz
Fixed missing constructor for DateRangeType
aaaf54c
@alanhartless @escopecz
Refactor slot_dwc to SlotDwcType
2ccf3e4
@alanhartless @escopecz
Refactor slot_imagecard to SlotImageCardType
00f8301
@alanhartless @escopecz
Refactor standalone_button to StandAloneButtonType
5a681e7
@alanhartless @escopecz
Refactor slot_segmentlist to SlotSegmentListType
b0270f9
@alanhartless @escopecz
Refactor GatedVideoType
57ba5bf
@alanhartless @escopecz
Remove MauticFactory from repositories
99eca5d
@alanhartless @escopecz
Refactor MauticFactory out of AssetGenerationHelper
b5ef733
@alanhartless @escopecz
Refactor MauticFactory out of TranslationLoader
28aabe6
@alanhartless @escopecz
Refactor MauticFactory from MenuRenderer
f76e089
@alanhartless @escopecz
Refactor MauticFactory from GravatarHelper
c3ba6ba
@alanhartless @escopecz
Refactor MauticFactory from AbstractMauticMigration.
8109c1f
@alanhartless @escopecz
Remove all migrations from 3.x; migration path is update schema to la…
678ccde 
…test 2.x series then migrate to M3
@alanhartless @escopecz
Refactor MauticFactory from ThemeHelper and TemplateNameParser
46bc6dc
@alanhartless @escopecz
Removed deprecated CoreEvents::* channel events
b24b3f0
@alanhartless @escopecz
Removed deprecated uses of $allowVisualPlaceholders argument
bc5021f
@alanhartless @escopecz
Fixed email dynamic email filter types
b3e2a1b
@alanhartless @escopecz
Removed unused classes
4b15a7b
@alanhartless @escopecz
Removed unused deprecated methods
1c11e09
@alanhartless @escopecz
Remove mcrypt cipher
9502037
@alanhartless @escopecz
Remove reference to mcrypt
e97fa06
@alanhartless @escopecz
Require adaptor for CacheStorageHelper
00622ae
@alanhartless @escopecz
Remove deprecated use of the plugin: permission prefix
55d5d73
@alanhartless @escopecz
Remove deprecated use of the plugin: permission prefix
c10f025
@alanhartless @escopecz
Removed custom button injection deprecated code
5f47dfa
@alanhartless @escopecz
Removed deprecated MauticJS.pixelLoaded method
5ce13ca
@alanhartless @escopecz
Removed another deprecated errors vs error response array
58344c8
@alanhartless @escopecz
Removed deprecated public slot used in 1.x templates
385924a
@alanhartless @escopecz
Remove deprecated getVersion method
9929d27
@alanhartless @escopecz
Define extended_type for custom core form extension
a2aa2a0
escopecz
escopecz approved these changes Nov 26, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I fixed the issues with Tel form type and now it seems the tests are passing and clicking though the UI is smooth now. I found an issue on the contact edit form but that's fixed now too.

@escopecz escopecz merged commit fc6c370 into m2-to-m3 Nov 26, 2019
@escopecz escopecz deleted the m3-8004 branch November 26, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alanhartless @escopecz