Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor deprecations in MauticEmailMarketing bundle (M3 migration) #8139

Merged
merged 12 commits into from Nov 26, 2019
Merged

Refactor deprecations in MauticEmailMarketing bundle (M3 migration) #8139

merged 12 commits into from Nov 26, 2019

Conversation

anton-vlasenko
Copy link
Contributor

@anton-vlasenko anton-vlasenko commented Nov 19, 2019 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? N
New feature? N
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8014
BC breaks?
Deprecations?

Description:

This PR containst changes that are neccessary to make MauticEmailMarketing bundle compatible with Symfony3.

Steps to test this PR:

  1. Load up this PR
  2. Go to Plugins, try to authenticate IContact and/or MailChimp and or ConstantContact integration.
  3. If you are able to authenticate them, it means that the EmailMarketingBundle works.

@anton-vlasenko anton-vlasenko added this to the 3.0.0 milestone Nov 19, 2019
@anton-vlasenko anton-vlasenko mentioned this pull request Nov 19, 2019
Closed
12 tasks
@escopecz escopecz self-requested a review November 21, 2019 15:50
@escopecz escopecz added code-review-needed PR's that require a code review before merging pending-feedback PR's and issues that are awaiting feedback from the author ready-to-test PR's that are ready to test labels Nov 21, 2019
@anton-vlasenko
Remove form aliases from config. They are deprecated.
c00fd4a
@anton-vlasenko
Add
d2c2f9b 
'choices_as_values' => true,
option for backwards compatibility with Symfony 2.7.
Because we have to test this task somehow.
@anton-vlasenko anton-vlasenko removed the pending-feedback PR's and issues that are awaiting feedback from the author label Nov 22, 2019
escopecz
escopecz approved these changes Nov 22, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! 👍

@escopecz escopecz removed the code-review-needed PR's that require a code review before merging label Nov 22, 2019
@escopecz
Copy link
Sponsor Member

I tested the forms the way that I commented out the if ($this->isAuthorized()) { condition in the EmailAbstractIntegration class so I could load the forms even without authorization. This way I discovered that the Mailchimp plugin is missing 1 dependency.

I tried to push it to your repo but was not successful.

Once you implement my change I'll merge this PR. I don't think we can hope for more testers from the community in a reasonable timeframe.

@escopecz
Copy link
Sponsor Member

Just to write down what I was testing for future generations, I tried to load config forms of these plugins:

  • iContact
  • Mailchimp
  • ConstantContact

@anton-vlasenko @escopecz
Update plugins/MauticEmailMarketingBundle/Config/config.php
8277c03 
Co-Authored-By: John Linhart <jan@linhart.email>
@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test labels Nov 26, 2019
@escopecz escopecz merged commit ac59369 into mautic:m2-to-m3 Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anton-vlasenko @escopecz