Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3 refactor cloud storage bundle #8147

Merged
merged 3 commits into from Nov 26, 2019
Merged

M3 refactor cloud storage bundle #8147

merged 3 commits into from Nov 26, 2019

Conversation

escopecz
Copy link
Sponsor Member

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Refactoring needed for upgrade to Symfony 3.4

Steps to test this PR:

  1. Load up this PR
  2. Go to Plugins
  3. Click on the Rackspace plugin and make sure the form loads fine.
  4. Click on the Openstack plugin and make sure the form loads fine.
  5. Click on the Amazon S3 plugin and make sure the form loads fine.

@escopecz escopecz added code-review-needed PR's that require a code review before merging T1 Low difficulty to fix (issue) or test (PR) Mautic 3 ready-to-test PR's that are ready to test labels Nov 22, 2019
@escopecz escopecz added this to the 3.0.0 milestone Nov 22, 2019
@escopecz escopecz mentioned this pull request Nov 22, 2019
Closed
5 tasks
anton-vlasenko
anton-vlasenko approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@anton-vlasenko anton-vlasenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine.
I've tested this using the steps provided by the author.
It works as described.
Therefore I approve this PR.

@anton-vlasenko
Copy link
Contributor

@escopecz Could you please merge and close this PR? (if needed)
I don't have permissions to do it.

@escopecz escopecz merged commit a5bddcc into mautic:m2-to-m3 Nov 26, 2019
@escopecz escopecz removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Nov 26, 2019
@escopecz escopecz mentioned this pull request Nov 26, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-vlasenko anton-vlasenko anton-vlasenko approved these changes

Assignees
No one assigned
Labels
T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@escopecz @anton-vlasenko