Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usage of deprecated ParameterBag code. #8180

Merged
merged 2 commits into from Dec 5, 2019

Conversation

dongilbert
Copy link
Member

Q A
Bug fix? N
New feature? N/A
Automated tests included? N/A
Related user documentation PR URL N/A
Related developer documentation PR URL https://github.com/symfony/symfony/blob/3.0/UPGRADE-3.0.md#httpfoundation
Issues addressed (#s or URLs) #8023
BC breaks? N
Deprecations? N

Description:

Removes deep item access from the request as documented in the symfony dev docs linked above.

Steps to test this PR:

  1. Load up this PR
  2. Test creating and editing throughout the app, specifically around
  • Assets
  • Campaigns
  • Campaign Events
  • Dynamic Content
  • Emails
  • Forms
  • Form Actions
  • Form Fields
  • Companies
  • Contacts
  • Notifications
  • Point Actions
  • Point Triggers
  • SMS
  • Stages
  • Profiles
  • Roles
  • Users
  • Profile (your own user)
  • Focus Items
  • Social items (twitter monitoring)

@escopecz
Copy link
Sponsor Member

escopecz commented Dec 4, 2019

If I try to save a Mautic user form I get
500 Internal Server Error - PHP Notice - Array to string conversion in /vendor/symfony/security/Core/Encoder/EncoderFactory.php:51

Can you replicate? I checked that I can save that form on the m2-to-m3 branch with no error.

@escopecz escopecz added Mautic 3 pending-feedback PR's and issues that are awaiting feedback from the author labels Dec 4, 2019
@escopecz escopecz added this to the 3.0.0 milestone Dec 4, 2019
@dongilbert dongilbert added ready-to-test PR's that are ready to test and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Dec 5, 2019
@dongilbert
Copy link
Member Author

Was able to reproduce, thanks @escopecz. Fixed

@escopecz
Copy link
Sponsor Member

escopecz commented Dec 5, 2019

I got 500 Internal Server Error - Permission must be in the format of bundle:permission:level (i.e. user:users:view). 'plugin:focus:items:viewown' given. on the form action form and the focus item edit form but it's not related to this PR and I think that @hluchas fixed it already in another PR. Just noting it here as FYI.

Other than that everything worked.

@escopecz escopecz merged commit de32f81 into mautic:m2-to-m3 Dec 5, 2019
@escopecz escopecz removed the ready-to-test PR's that are ready to test label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants