New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M3: Mailer Transports - SMTP Transports #8193
Merged
escopecz
merged 13 commits into
mautic:3.x
from
anton-vlasenko:m3-refactor-swiftmailer-new-branch
Dec 5, 2019
Merged
M3: Mailer Transports - SMTP Transports #8193
escopecz
merged 13 commits into
mautic:3.x
from
anton-vlasenko:m3-refactor-swiftmailer-new-branch
Dec 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's deprecated.
…essage. Add ping methods.
… a string to replace tokens.
We have to mock the constructor.
Now it should be unserialized correctly.
…factor-swiftmailer-new-branch # Conflicts: # app/bundles/EmailBundle/Swiftmailer/Momentum/Callback/MomentumCallback.php # app/bundles/EmailBundle/Swiftmailer/Momentum/Callback/MomentumCallbackInterface.php # app/bundles/EmailBundle/Swiftmailer/SendGrid/Mail/SendGridMailAttachment.php # app/bundles/EmailBundle/Swiftmailer/SendGrid/Mail/SendGridMailMetadata.php # app/bundles/EmailBundle/Swiftmailer/SendGrid/Mail/SendGridMailPersonalization.php # app/bundles/EmailBundle/Swiftmailer/Transport/AbstractTokenArrayTransport.php # app/bundles/EmailBundle/Swiftmailer/Transport/AbstractTokenHttpTransport.php # app/bundles/EmailBundle/Swiftmailer/Transport/AbstractTokenSmtpTransport.php # app/bundles/EmailBundle/Swiftmailer/Transport/ElasticemailTransport.php # app/bundles/EmailBundle/Swiftmailer/Transport/MailjetTransport.php # app/bundles/EmailBundle/Swiftmailer/Transport/MomentumTransport.php # app/bundles/EmailBundle/Swiftmailer/Transport/SendgridApiTransport.php # app/bundles/EmailBundle/Swiftmailer/Transport/SparkpostTransport.php # app/bundles/EmailBundle/Tests/Helper/Transport/BatchTransport.php # app/bundles/EmailBundle/Tests/Helper/Transport/BcInterfaceTokenTransport.php # app/bundles/EmailBundle/Tests/Swiftmailer/SendGrid/Mail/SendGridMailAttachmentTest.php # app/bundles/EmailBundle/Tests/Swiftmailer/SendGrid/Mail/SendGridMailBaseTest.php # app/bundles/EmailBundle/Tests/Swiftmailer/SendGrid/Mail/SendGridMailMetadataTest.php # app/bundles/EmailBundle/Tests/Swiftmailer/SendGrid/Mail/SendGridMailPersonalizationTest.php # composer.json # composer.lock
In ReplaceAliasByActualDefinitionPass.php line 57: Unable to replace alias "swiftmailer.mailer.default.transport.real" with ac tual definition "mail". In ContainerBuilder.php line 1061: You have requested a non-existent service "mail". Script Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::clearCache handling the post-install-cmd event terminated with an exception [RuntimeException] An error occurred when executing the "'cache:clear --no-warmup'" command: In ReplaceAliasByActualDefinitionPass.php line 57: Unable to replace alias "swiftmailer.mailer.default.transport.real" with ac tual definition "mail". In ContainerBuilder.php line 1061: You have requested a non-existent service "mail".
anton-vlasenko
changed the title
https://github.com/mautic/mautic/pull/8192
M3: Mailer Transports - SMTP Transports
Dec 5, 2019
escopecz
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mautic loads for me. Now with the smtp
email transport too.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #8192.
Basically it's the same PR but this PR is supposed to be merged into 3.x.