Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3: Mailer Transports - SMTP Transports #8193

Merged
merged 13 commits into from Dec 5, 2019
Merged

M3: Mailer Transports - SMTP Transports #8193

merged 13 commits into from Dec 5, 2019

Conversation

anton-vlasenko
Copy link
Contributor

Please see #8192.
Basically it's the same PR but this PR is supposed to be merged into 3.x.

We have to mock the constructor.
Now it should be unserialized correctly.
…factor-swiftmailer-new-branch

# Conflicts:
#	app/bundles/EmailBundle/Swiftmailer/Momentum/Callback/MomentumCallback.php
#	app/bundles/EmailBundle/Swiftmailer/Momentum/Callback/MomentumCallbackInterface.php
#	app/bundles/EmailBundle/Swiftmailer/SendGrid/Mail/SendGridMailAttachment.php
#	app/bundles/EmailBundle/Swiftmailer/SendGrid/Mail/SendGridMailMetadata.php
#	app/bundles/EmailBundle/Swiftmailer/SendGrid/Mail/SendGridMailPersonalization.php
#	app/bundles/EmailBundle/Swiftmailer/Transport/AbstractTokenArrayTransport.php
#	app/bundles/EmailBundle/Swiftmailer/Transport/AbstractTokenHttpTransport.php
#	app/bundles/EmailBundle/Swiftmailer/Transport/AbstractTokenSmtpTransport.php
#	app/bundles/EmailBundle/Swiftmailer/Transport/ElasticemailTransport.php
#	app/bundles/EmailBundle/Swiftmailer/Transport/MailjetTransport.php
#	app/bundles/EmailBundle/Swiftmailer/Transport/MomentumTransport.php
#	app/bundles/EmailBundle/Swiftmailer/Transport/SendgridApiTransport.php
#	app/bundles/EmailBundle/Swiftmailer/Transport/SparkpostTransport.php
#	app/bundles/EmailBundle/Tests/Helper/Transport/BatchTransport.php
#	app/bundles/EmailBundle/Tests/Helper/Transport/BcInterfaceTokenTransport.php
#	app/bundles/EmailBundle/Tests/Swiftmailer/SendGrid/Mail/SendGridMailAttachmentTest.php
#	app/bundles/EmailBundle/Tests/Swiftmailer/SendGrid/Mail/SendGridMailBaseTest.php
#	app/bundles/EmailBundle/Tests/Swiftmailer/SendGrid/Mail/SendGridMailMetadataTest.php
#	app/bundles/EmailBundle/Tests/Swiftmailer/SendGrid/Mail/SendGridMailPersonalizationTest.php
#	composer.json
#	composer.lock
In ReplaceAliasByActualDefinitionPass.php line 57:
  Unable to replace alias "swiftmailer.mailer.default.transport.real" with ac
  tual definition "mail".
In ContainerBuilder.php line 1061:
  You have requested a non-existent service "mail".
Script Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::clearCache handling the post-install-cmd event terminated with an exception              [RuntimeException]
An error occurred when executing the "'cache:clear --no-warmup'" command:
In ReplaceAliasByActualDefinitionPass.php line 57:
Unable to replace alias "swiftmailer.mailer.default.transport.real" with ac
    tual definition "mail".

  In ContainerBuilder.php line 1061:

    You have requested a non-existent service "mail".
@anton-vlasenko anton-vlasenko changed the title https://github.com/mautic/mautic/pull/8192 M3: Mailer Transports - SMTP Transports Dec 5, 2019
@anton-vlasenko anton-vlasenko added this to the 3.0.0 milestone Dec 5, 2019
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mautic loads for me. Now with the smtp email transport too.

@escopecz escopecz merged commit 6d28c75 into mautic:3.x Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants