Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3: Updates for JMS Serializer Compatibility #8201

Merged
merged 9 commits into from Dec 11, 2019
Merged

M3: Updates for JMS Serializer Compatibility #8201

merged 9 commits into from Dec 11, 2019

Conversation

dongilbert
Copy link
Member

@dongilbert dongilbert commented Dec 6, 2019 •
edited by escopecz

  • Stopped extending a file-based metadata driver
  • implemented the driver interface directly
  • Fallback to property name when serializing unless a specific serializedName has been set

Issue: #8027

Testing:
Compare API output from various endpoints in your production Mautic to the new API output - ensure consistency

@dongilbert dongilbert changed the base branch from staging to m2-to-m3 December 6, 2019 17:46
@dongilbert dongilbert changed the base branch from m2-to-m3 to 3.x December 6, 2019 17:47
@escopecz
Copy link
Sponsor Member

escopecz commented Dec 9, 2019

PHPSTAN is running. Great stuff!

@dongilbert dongilbert added the essential This must be done to close the milestone label Dec 10, 2019
@dongilbert dongilbert changed the title [WIP] M3: Updates for JMS Serializer Compatibility M3: Updates for JMS Serializer Compatibility Dec 10, 2019
escopecz
escopecz approved these changes Dec 11, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot confirm that all API endpoints return the same responses as before as I cannot run API Library tests against this branch as each require different PHP version, but I'm all for merging this as it's step to the right direction. 👍

@escopecz escopecz added Mautic 3 ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Dec 11, 2019
@escopecz escopecz added this to the 3.0.0 milestone Dec 11, 2019
@escopecz escopecz merged commit 7cca968 into mautic:3.x Dec 11, 2019
@dongilbert
Copy link
Member Author

I've run the API Library tests against this with both on my local. PHP 7.2.22

@escopecz
Copy link
Sponsor Member

Interesting. Api Library fails for me. Thanks for running it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
essential This must be done to close the milestone ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dongilbert @escopecz