Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3: Refactor builder token helper #8204

Merged
merged 20 commits into from
Dec 19, 2019
Merged

M3: Refactor builder token helper #8204

merged 20 commits into from
Dec 19, 2019

Commits on Dec 9, 2019

  1. Initial commit for refactoring MauticFactory out of BuilderTokenHelper

    @mtshaw3
    mtshaw3 committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    3b18789 View commit details
    Browse the repository at this point in the history

  2. Created new HelperTokenBuilderFactory to provide instances of HelperT… 

    …okenBuilder.

Refactored out use of MauticFactory from HelperTokenBuilder.
Made HelperTokenBuilder a service.
    @mtshaw3
    mtshaw3 committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    1fb4fce View commit details
    Browse the repository at this point in the history

  3. Clean up builder subscribers a bit. Use ContactTracker instead of dep… 

    …recated leadModel->getCurrentLead()
    @dongilbert @mtshaw3
    dongilbert authored and mtshaw3 committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    1646ce6 View commit details
    Browse the repository at this point in the history

  4. Revert the addTokensFromHelper to be consistent with previous code

    @dongilbert @mtshaw3
    dongilbert authored and mtshaw3 committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    7d17943 View commit details
    Browse the repository at this point in the history

  5. Import missing class name

    @dongilbert @mtshaw3
    dongilbert authored and mtshaw3 committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    80f3e1a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'm2-to-m3' into refactor-builder-token-helper

    @mtshaw3
    mtshaw3 committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    50a4cf6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'm2-to-m3' into refactor-builder-token-helper

    @mtshaw3
    mtshaw3 committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    6bda906 View commit details
    Browse the repository at this point in the history

  8. Fixes for build problem from merge

    @mtshaw3
    mtshaw3 committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    6235518 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. changes from code review

    @mtshaw3
    mtshaw3 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    7429549 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'm2-to-m3' into refactor-builder-token-helper

    @mtshaw3
    mtshaw3 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    bb4892c View commit details
    Browse the repository at this point in the history

  3. fixing build error

    @mtshaw3
    mtshaw3 committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    514c1ce View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Update plugins/MauticFocusBundle/EventListener/PageSubscriber.php 

    Co-Authored-By: John Linhart <jan@linhart.email>
    @mtshaw3 @escopecz
    mtshaw3 and escopecz committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    da1cd8c View commit details
    Browse the repository at this point in the history

  2. changes for code review

    @mtshaw3
    mtshaw3 committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    c6f305d View commit details
    Browse the repository at this point in the history

  3. fixing build error

    @mtshaw3
    mtshaw3 committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    fedfbed View commit details
    Browse the repository at this point in the history

  4. fixed build error

    @mtshaw3
    mtshaw3 committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    7a122b9 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Update app/bundles/CoreBundle/Helper/BuilderTokenHelper.php 

    Co-Authored-By: John Linhart <jan@linhart.email>
    @mtshaw3 @escopecz
    mtshaw3 and escopecz committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    912cef1 View commit details
    Browse the repository at this point in the history

  2. changes for code review

    @mtshaw3
    mtshaw3 committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    49b4f4f View commit details
    Browse the repository at this point in the history

  3. removed useless doc blocks

    @mtshaw3
    mtshaw3 committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    3de4a18 View commit details
    Browse the repository at this point in the history

  4. fixed issue with resolving repository from model name

    @mtshaw3
    mtshaw3 committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    ddab0e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. updated dependencies for builderTokenHelperFactory

    @mtshaw3
    mtshaw3 committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    c1cba19 View commit details
    Browse the repository at this point in the history