-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New webhook: Contact Company Subscription Change #8218
New webhook: Contact Company Subscription Change #8218
Conversation
Hi there! We now want to integrate your contribution in the Mautic 3 roadmap as 3.1.0 candidate. How to do?
Please report results by commenting on your PR to make us administration easier. You can more information on how to do all of that on this blog post "Getting you PR ready for Mautic 3". |
6ea9c1b
to
6664966
Compare
Rebsed |
Travis tests have failedHey @kuzmany, TravisBuddy Request Identifier: 05bd4c50-7f4e-11ea-b434-f745fa9560ca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this PR, it works as expected I got a webhook on company change and it included the company that got added correctly to the contact
c5209cb
to
fab5543
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works great - adding and removing companies - and the content includes the information about both the company and the contact.
Thanks for the PR @kuzmany 🙇
Marking this as RTC subject to the checks being passed successfully - I have a suspicion it might possibly need tests but we'll see! |
Codecov Report
@@ Coverage Diff @@
## staging #8218 +/- ##
=============================================
+ Coverage 29.89% 29.90% +0.01%
- Complexity 33278 33281 +3
=============================================
Files 1938 1938
Lines 115242 115255 +13
=============================================
+ Hits 34447 34463 +16
+ Misses 80795 80792 -3
|
fab5543
to
f83a84c
Compare
f83a84c
to
af4a9d7
Compare
@kuzmany I just added a test for this PR, if Travis/Codecov pass this is RTC 👍 |
This pull request has been mentioned on Mautic Community Forums. There might be relevant details there: https://forum.mautic.org/t/mautic-3-1-new-beginnings/15787/1 |
Please be sure you are submitting this against the staging branch.
Description:
New webhook event send when contact's companies are changed (added/removed).
Response return
Steps to test this PR:
List deprecations along with the new alternative:
List backwards compatibility breaks: