Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integrations bundle tests #8223

Merged
merged 4 commits into from Dec 13, 2019

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Dec 12, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8212
BC breaks?
Deprecations?

Description:

This is the second step after #8210. The bundle is now registered into kernel and all tests are passing for this bundle.

There are still some other tests failing but those will be dealt with later.

Steps to test this PR:

  1. Just look at Travis and search for "IntegrationsBundle". There should be no tests failing for this bundle.

@escopecz escopecz added code-review-needed PR's that require a code review before merging Mautic 3 ready-to-test PR's that are ready to test labels Dec 12, 2019
@escopecz escopecz added this to the 3.0.0 milestone Dec 12, 2019
@dongilbert
Copy link
Member

Doesn't add any new failures to the tests, looks good. Thanks @escopecz

@dongilbert dongilbert merged commit b2dcbfb into mautic:3.x Dec 13, 2019
@escopecz escopecz deleted the fix-integrations-bundle-tests branch December 13, 2019 16:08
@escopecz escopecz removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants