Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3 point bundle #8230

Merged
merged 20 commits into from Dec 13, 2019
Merged

M3 point bundle #8230

merged 20 commits into from Dec 13, 2019

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Dec 13, 2019 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7997
BC breaks? Surprisingly none
Deprecations? Surprisingly none

Description:

Continuation of #8052. This PR fixes issues from that PR and adds PointBundle to the PHPSTAN CI check.

Steps to test this PR:

  1. Load up this PR
  2. Test all point related forms. Point actions, Point triggers, Form and Campaign point actions.

There is known issue with Focus items permissions that is dealt with in another bundle. But if you wait a little longer then the forms will show up.

This was referenced Dec 13, 2019
Closed
Closed
@escopecz escopecz changed the base branch from staging to m2-to-m3 December 13, 2019 08:37
@escopecz escopecz added code-review-needed PR's that require a code review before merging Mautic 3 ready-to-test PR's that are ready to test labels Dec 13, 2019
@escopecz escopecz added this to the 3.0.0 milestone Dec 13, 2019
@hluchas hluchas self-requested a review December 13, 2019 12:07
dongilbert
dongilbert previously approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@dongilbert dongilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review lgtm

@dongilbert dongilbert added the pending-test-confirmation PR's that require one test before they can be merged label Dec 13, 2019
hluchas
hluchas suggested changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@hluchas hluchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 :'-(

app/bundles/PointBundle/Form/Type/TriggerType.php Outdated Show resolved Hide resolved
dongilbert
dongilbert approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@dongilbert dongilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the unused import. Other things lgtm

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test labels Dec 13, 2019
@escopecz escopecz merged commit 5097199 into mautic:m2-to-m3 Dec 13, 2019
@escopecz escopecz deleted the M3-PointBundle branch December 13, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongilbert dongilbert dongilbert approved these changes

@hluchas hluchas Awaiting requested review from hluchas

Assignees
No one assigned
Labels
ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@escopecz @dongilbert @hluchas @Dcoutelle