Segment public name property for preference center #8238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npracht
added
enhancement
|
Hi there! We now want to integrate your contribution in the Mautic 3 roadmap as 3.1.0 candidate. How to do?
Please report results by commenting on your PR to make us administration easier. You can more information on how to do all of that on this blog post "Getting you PR ready for Mautic 3". |
patrykgruszka
force-pushed
the
segment-public-name
branch
from
810f5ea
to
7fc0731
Compare
Travis tests have failedHey @patrykgruszka, 2nd Buildif [ ${TRAVIS_PHP_VERSION:0:3} == "7.3" ]; then composer test -- --coverage-clover=coverage.xml && bash <(curl -s https://codecov.io/bash); else composer test; fiTravisBuddy Request Identifier: b799d960-c1c6-11ea-8e31-7fd6e6dac888 |
Travis tests have failedHey @patrykgruszka, 2nd Buildif [ ${TRAVIS_PHP_VERSION:0:3} == "7.3" ]; then composer test -- --coverage-clover=coverage.xml && bash <(curl -s https://codecov.io/bash); else composer test; fiTravisBuddy Request Identifier: 19878b90-c1e0-11ea-8e31-7fd6e6dac888 |
Codecov Report
@@ Coverage Diff @@
## staging #8238 +/- ##
=============================================
+ Coverage 31.17% 31.44% +0.27%
- Complexity 33546 33558 +12
=============================================
Files 1943 1943
Lines 116002 115828 -174
=============================================
+ Hits 36162 36422 +260
+ Misses 79840 79406 -434
|
|
Hi @npracht, this PR is adapted to version 3 and ready to merge. |
npracht
added
mautic-3
ready-to-test
|
@cla-bot check |
|
Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact @RCheesley. CLA has not been signed by @patrykgruszka. |
|
The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings! |
|
@patrykgruszka thanks for submitting the PR - what a useful feature! In order for us to consider this for merging in 3.2 we will require you to sign the Contributors Agreement - please see the link above in the comments. This is a one-time thing that all contributors need to do, once it's signed we can accept all your PR's going forward. We will then need to get it tested and should be able to get it merged with the next minor release at the end of November. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings! |
kuzmany
previously approved these changes
Oct 25, 2020
kuzmany
added
pending-test-confirmation
RCheesley
previously approved these changes
Nov 20, 2020
There was a problem hiding this comment.
@patrykgruszka looks like we need to rebase against staging for this one - can you take a look? We will also need a PR to the documentation page on segmentation explaining how to use this feature - https://github.com/mautic/mautic-documentation/blob/master/pages/09.contacts/03.manage-segments/docs.en.md here is the file to edit.
I was able to test this up to checking it appearing on the landing page, as I can't edit the settings on Mautibox (settings which are system-set are getting cleared so you cannot save the settings).
Based on other +1's I'm good with getting this merged providing Codecov passes after a rebase and the documentation PR is made.
RCheesley
removed
the
pending-test-confirmation
RCheesley
added
the
needs-documentation
RCheesley
force-pushed
the
segment-public-name
branch
from
ebfd236
to
6d284cf
Compare
RCheesley
previously approved these changes
Nov 21, 2020
RCheesley
added a commit
to RCheesley/mautic-documentation
that referenced
this pull request
Nov 21, 2020
RCheesley
removed
needs-documentation
RCheesley
approved these changes
Nov 21, 2020
|
This pull request has been mentioned on Mautic Community Forums. There might be relevant details there: https://forum.mautic.org/t/mautic-3-2-growing-together/17244/1 |
RCheesley
added a commit
to mautic/mautic-documentation
that referenced
this pull request
Dec 2, 2020
* Improve segment documentation and add documentation to support mautic/mautic#8238 * Clarify we're talking about the contact not the Mautic user * Grammar fix 🤦 * Grammar again.... more coffee needed 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the staging branch.
Description:
This PR added new segment property - public name which is visible in preference center. Includes migration that sets Public name with same value as Name. Public name value is not required and
Steps to test this PR:
php app/console doctrine:migrations:migrate