Fixes some missed form alias uses in the QueueBundle #8239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hluchas
suggested changes
Dec 17, 2019
hluchas
approved these changes
Dec 17, 2019
anton-vlasenko
suggested changes
Dec 17, 2019
There was a problem hiding this comment.
@alanhartless Sorry about those form types. I haven't noticed them.
I've code reviewed and tested this PR and didn't find any errors.
Do I have to merge it to 3.x on my local and test it there as well?
Is it enough to test the current branch only?
anton-vlasenko
added
the
pending-feedback
escopecz
removed
the
pending-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QueueBundle uses an event to register form fields which threw exceptions when loading the Configuration in M3. This replaces those with FQCN.
To test, load Mautic's configuration and view the Queue bundle's settings. Select a queue and the related configuration fields should continue to show.