Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package release script for m3 #8269

Merged
merged 1 commit into from Jan 6, 2020
Merged

Fix package release script for m3 #8269

merged 1 commit into from Jan 6, 2020

Conversation

escopecz
Copy link
Sponsor Member

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) #8260
BC breaks? N
Deprecations? N

Description:

In M3 the console script was moved from the app to the bin directory. That was the only issue in the build script

Steps to reproduce the bug:

  1. Run php build/package_release.php -b=3.x
  2. It will fail with an error that app/console does not exist

Steps to test this PR:

  1. Run the command again
  2. It will finish and create production zip files in build/packages dir

@escopecz escopecz changed the base branch from staging to 3.x December 30, 2019 13:22
@escopecz escopecz added code-review-needed PR's that require a code review before merging Mautic 3 ready-to-test PR's that are ready to test labels Dec 30, 2019
@escopecz escopecz added this to the 3.0.0 milestone Dec 30, 2019
@escopecz escopecz mentioned this pull request Dec 30, 2019
Closed
4 tasks
@escopecz escopecz force-pushed the fix-package_release-script-for-M3 branch from af94bdc to 3f5c0c7 Compare December 31, 2019 14:46
@hluchas hluchas self-requested a review January 6, 2020 14:50
hluchas
hluchas reviewed Jan 6, 2020
View reviewed changes
Copy link
Contributor

@hluchas hluchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Works and installation too

@escopecz escopecz merged commit c0cbc78 into mautic:3.x Jan 6, 2020
@escopecz escopecz removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hluchas hluchas hluchas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@escopecz @hluchas