Segment filters based on entity select box fixes

[escopecz]

Please be sure you are submitting this against the staging branch.

Q	A
Bug fix?	Y
New feature?	N
Automated tests included?	N
Related user documentation PR URL	/
Related developer documentation PR URL	/
Issues addressed (#s or URLs)	/
BC breaks?	N
Deprecations?	N

Description:

@dongilbert noticed that the segment filters based on entity select boxes does not work correctly. This PR fixes that.

Steps to reproduce the bug:

1. Create a new segment filter based on asset downloads.
2. Change filter to including so you could see the select box.
3. Notice the list looks correct. You can see the asset IDs instead of labels.
4. Save the segment.
5. You get a validation error and if you check the asset select box now you can see labels instead of IDs.

Steps to test this PR:

1. Load up this PR
2. Follow the steps now. There should not be any IDs visible in the select box and no validation error.

[hluchas]

I'm not able to create new asset. I know that this could not be part of this fix, but I can't test it for now.

Error produced on URL /index_dev.php/s/assets/new

[2020-01-02 14:55:17] mautic.CRITICAL: Uncaught PHP Exception Symfony\Component\Form\Exception\InvalidArgumentException: "Could not load type "datetime": class does not implement "Symfony\Component\Form\FormTypeInterface"." at /Users/lukas.drahy/dev/community-fork/vendor/symfony/form/FormRegistry.php line 89 {"exception":"[object] (Symfony\\Component\\Form\\Exception\\InvalidArgumentException(code: 0): Could not load type \"datetime\": class does not implement \"Symfony\\Component\\Form\\FormTypeInterface\". at /Users/lukas.drahy/dev/community-fork/vendor/symfony/form/FormRegistry.php:89)
[stacktrace]
#0 /Users/lukas.drahy/dev/community-fork/vendor/symfony/form/FormFactory.php(74): Symfony\\Component\\Form\\FormRegistry->getType('datetime')
#1 /Users/lukas.drahy/dev/community-fork/vendor/symfony/form/FormBuilder.php(98): Symfony\\Component\\Form\\FormFactory->createNamedBuilder('publishUp', 'datetime', NULL, Array)
#2 /Users/lukas.drahy/dev/community-fork/vendor/symfony/form/FormBuilder.php(252): Symfony\\Component\\Form\\FormBuilder->create('publishUp', 'datetime', Array)
#3 /Users/lukas.drahy/dev/community-fork/vendor/symfony/form/FormBuilder.php(199): Symfony\\Component\\Form\\FormBuilder->resolveChildren()
#4 /Users/lukas.drahy/dev/community-fork/vendor/symfony/form/FormFactory.php(30): Symfony\\Component\\Form\\FormBuilder->getForm()
#5 /Users/lukas.drahy/dev/community-fork/app/bundles/AssetBundle/Model/AssetModel.php(388): Symfony\\Component\\Form\\FormFactory->create('Mautic\\\\AssetBun...', Object(Mautic\\AssetBundle\\Entity\\Asset), Array)
#6 /Users/lukas.drahy/dev/community-fork/app/bundles/AssetBundle/Controller/AssetController.php(327): Mautic\\AssetBundle\\Model\\AssetModel->createForm(Object(Mautic\\AssetBundle\\Entity\\Asset), Object(Symfony\\Component\\Form\\FormFactory), '/index_dev.php/...')
#7 /Users/lukas.drahy/dev/community-fork/app/bundles/CoreBundle/Controller/CommonController.php(474): Mautic\\AssetBundle\\Controller\\AssetController->newAction(Object(Mautic\\AssetBundle\\Entity\\Asset), '')
#8 /Users/lukas.drahy/dev/community-fork/vendor/symfony/http-kernel/HttpKernel.php(151): Mautic\\CoreBundle\\Controller\\CommonController->executeAction('new', 0, 0, '')
#9 /Users/lukas.drahy/dev/community-fork/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\\Component\\HttpKernel\\HttpKernel->handleRaw(Object(Symfony\\Component\\HttpFoundation\\Request), 1)
#10 /Users/lukas.drahy/dev/community-fork/vendor/symfony/http-kernel/Kernel.php(200): Symfony\\Component\\HttpKernel\\HttpKernel->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#11 /Users/lukas.drahy/dev/community-fork/app/AppKernel.php(141): Symfony\\Component\\HttpKernel\\Kernel->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#12 /Users/lukas.drahy/dev/community-fork/app/middlewares/CORSMiddleware.php(93): AppKernel->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#13 /Users/lukas.drahy/dev/community-fork/app/middlewares/CatchExceptionMiddleware.php(45): Mautic\\Middleware\\CORSMiddleware->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#14 /Users/lukas.drahy/dev/community-fork/app/middlewares/Dev/IpRestrictMiddleware.php(66): Mautic\\Middleware\\CatchExceptionMiddleware->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#15 /Users/lukas.drahy/dev/community-fork/app/middlewares/VersionCheckMiddleware.php(55): Mautic\\Middleware\\Dev\\IpRestrictMiddleware->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#16 /Users/lukas.drahy/dev/community-fork/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Mautic\\Middleware\\VersionCheckMiddleware->handle(Object(Symfony\\Component\\HttpFoundation\\Request), 1, true)
#17 /Users/lukas.drahy/dev/community-fork/vendor/stack/run/src/Stack/run.php(13): Stack\\StackedHttpKernel->handle(Object(Symfony\\Component\\HttpFoundation\\Request))
#18 /Users/lukas.drahy/dev/community-fork/index_dev.php(24): Stack\
un(Object(Stack\\StackedHttpKernel))
#19 {main}
"} 

Issue created #8282

EDIT:
I tried tags and form selects are empty

Fixed in other issue

[hluchas]

operators in app/bundles/LeadBundle/Assets/js/lead.js:667 is undefined for me in case of using Asset downloads filter

[escopecz]

I cannot replicate the issue. Can someone else test it?

[mtshaw3]

Appears to be working for me