Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wysiwyg #8281

Merged
merged 5 commits into from Jan 2, 2020
Merged

Fix wysiwyg #8281

merged 5 commits into from Jan 2, 2020

Conversation

anton-vlasenko
Copy link
Contributor

@anton-vlasenko anton-vlasenko commented Jan 2, 2020 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8280
BC breaks?
Deprecations?

Description:

Steps to reproduce

  1. You have to be on 3.x branch to reproduce this.
  2. Go to Landing pages, create a new landing page.
  3. Open up Builder.
  4. You will see the following error in the console.
    Screenshot 2020-01-02 at 12 12 39

Steps to test

  1. Repeat steps 1-3 from "Steps to reproduce"
  2. There will be no error in the console.

@anton-vlasenko anton-vlasenko added this to the 3.0.0 milestone Jan 2, 2020
@anton-vlasenko anton-vlasenko added code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test bug Issues or PR's relating to bugs labels Jan 2, 2020
escopecz
escopecz approved these changes Jan 2, 2020
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Thanks Anton! 👍

@escopecz escopecz merged commit d42d440 into mautic:3.x Jan 2, 2020
@escopecz escopecz removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anton-vlasenko @escopecz