Refactored out PHPExcel library to use PHPSpreadsheet instead #8286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escopecz
reviewed
Jan 7, 2020
|
@escopecz Can you check the conflicts for composer.lock? I was going to update it but i dont know the right changes from the new versions in the composer.json. |
|
Always the higher number. I'll resolve it tomorrow if you won't get to it. |
I understand that, I just wasn't sure about what should happen to the composer.lock file, because the hash has changed. |
|
At this point, I'd remove it and run |
Co-Authored-By: John Linhart <jan@linhart.email>
|
I tested report export to Excel and form submit export to Excel and it works fine. Nice work @mtshaw3! 👍 |
escopecz
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced PHPExcel Library with PHPSpreadsheet library
#8267
https://backlog.acquia.com/browse/MAUT-3201